mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-01 23:03:54 -06:00
include: Make headers more self-contained
Back in 2016, we discussed[1] rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are needed for some reason, they must be documented in the header. If all that's needed from a header is typedefs, put those into qemu/typedefs.h instead of including the header. 3. Cyclic inclusion is forbidden. This patch gets include/ closer to obeying 2. It's actually extracted from my "[RFC] Baby steps towards saner headers" series[2], which demonstrates a possible path towards checking 2 automatically. It passes the RFC test there. [1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org> https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html [2] Message-Id: <20190711122827.18970-1-armbru@redhat.com> https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Message-Id: <20190812052359.30071-2-armbru@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
This commit is contained in:
parent
f8f2eac4e5
commit
ec150c7e09
106 changed files with 183 additions and 8 deletions
|
@ -16,9 +16,12 @@
|
|||
* You should have received a copy of the GNU Lesser General Public
|
||||
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
#ifndef CPUTLB_H
|
||||
#define CPUTLB_H
|
||||
|
||||
#include "exec/cpu-common.h"
|
||||
|
||||
#if !defined(CONFIG_USER_ONLY)
|
||||
/* cputlb.c */
|
||||
void tlb_protect_code(ram_addr_t ram_addr);
|
||||
|
|
|
@ -20,6 +20,7 @@
|
|||
#ifndef EXEC_ALL_H
|
||||
#define EXEC_ALL_H
|
||||
|
||||
#include "cpu.h"
|
||||
#include "exec/tb-context.h"
|
||||
#include "sysemu/cpus.h"
|
||||
|
||||
|
|
|
@ -24,6 +24,8 @@
|
|||
#ifndef IOPORT_H
|
||||
#define IOPORT_H
|
||||
|
||||
#include "exec/memory.h"
|
||||
|
||||
#define MAX_IOPORTS (64 * 1024)
|
||||
#define IOPORTS_MASK (MAX_IOPORTS - 1)
|
||||
|
||||
|
|
|
@ -20,6 +20,8 @@
|
|||
#ifndef MEMORY_INTERNAL_H
|
||||
#define MEMORY_INTERNAL_H
|
||||
|
||||
#include "cpu.h"
|
||||
|
||||
#ifndef CONFIG_USER_ONLY
|
||||
static inline AddressSpaceDispatch *flatview_to_dispatch(FlatView *fv)
|
||||
{
|
||||
|
|
|
@ -20,6 +20,7 @@
|
|||
#define RAM_ADDR_H
|
||||
|
||||
#ifndef CONFIG_USER_ONLY
|
||||
#include "cpu.h"
|
||||
#include "hw/xen/xen.h"
|
||||
#include "sysemu/tcg.h"
|
||||
#include "exec/ramlist.h"
|
||||
|
|
|
@ -10,6 +10,8 @@
|
|||
#ifndef SOFTMMU_SEMI_H
|
||||
#define SOFTMMU_SEMI_H
|
||||
|
||||
#include "cpu.h"
|
||||
|
||||
static inline uint64_t softmmu_tget64(CPUArchState *env, target_ulong addr)
|
||||
{
|
||||
uint64_t val;
|
||||
|
|
|
@ -20,6 +20,8 @@
|
|||
#ifndef EXEC_TB_HASH_H
|
||||
#define EXEC_TB_HASH_H
|
||||
|
||||
#include "exec/cpu-defs.h"
|
||||
#include "exec/exec-all.h"
|
||||
#include "qemu/xxhash.h"
|
||||
|
||||
#ifdef CONFIG_SOFTMMU
|
||||
|
|
|
@ -16,10 +16,12 @@
|
|||
* You should have received a copy of the GNU Lesser General Public
|
||||
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
#ifndef THUNK_H
|
||||
#define THUNK_H
|
||||
|
||||
#include "cpu.h"
|
||||
#include "exec/user/abitypes.h"
|
||||
|
||||
/* types enums definitions */
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue