motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-08 18:23:57 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

qemu-storage-daemon: Fix non-string --object properties

Browse source 
After processing the option string with the keyval parser, we get a
QDict that contains only strings. This QDict must be fed to a keyval
visitor which converts the strings into the right data types.

qmp_object_add(), however, uses the normal QObject input visitor, which
expects a QDict where all properties already have the QType that matches
the data type required by the QOM object type.

Change the --object implementation in qemu-storage-daemon so that it
doesn't call qmp_object_add(), but calls user_creatable_add_dict()
directly instead and pass it a new keyval boolean that decides which
visitor must be used.

Reported-by: Coiby Xu <coiby.xu@gmail.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Kevin Wolf 2020-04-16 17:26:06 +02:00
parent d6a5beeb2b
commit eaae29ef89
4 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
qom/qom-qmp-cmds.c
View file

@ -263,7 +263,7 @@ void qmp_object_add(QDict *qdict, QObject **ret_data, Error **errp)
qobject_unref(pdict);
}
user_creatable_add_dict(qdict, errp);
user_creatable_add_dict(qdict, false, errp);
}
void qmp_object_del(const char *id, Error **errp)