motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-03 07:43:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

spapr: Do NVDIMM/PC-DIMM device hotplug sanity checks at pre-plug only

Browse source 
Pre-plug of a memory device, be it an NVDIMM or a PC-DIMM, ensures
that the memory slot is available and that addresses don't overlap
with existing memory regions. The corresponding DRCs in the LMB
and PMEM namespaces are thus necessarily attachable at plug time.

Pass &error_abort to spapr_drc_attach() in spapr_add_lmbs() and
spapr_add_nvdimm(). This allows to greatly simplify error handling
on the plug path.

Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <20201120234208.683521-3-groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Greg Kurz 2020-11-21 00:42:01 +01:00 • committed by David Gibson
parent 9e4dc0a1c2
commit ea042c53f4
3 changed files with 20 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/hw/ppc/spapr_nvdimm.h
View file

@ -30,6 +30,6 @@ int spapr_pmem_dt_populate(SpaprDrc *drc, SpaprMachineState *spapr,
void spapr_dt_persistent_memory(SpaprMachineState *spapr, void *fdt);
bool spapr_nvdimm_validate(HotplugHandler *hotplug_dev, NVDIMMDevice *nvdimm,
uint64_t size, Error **errp);
bool spapr_add_nvdimm(DeviceState *dev, uint64_t slot, Error **errp);
void spapr_add_nvdimm(DeviceState *dev, uint64_t slot);
#endif