mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-05 16:53:55 -06:00
snapshot: create helper to test that block drivers supports snapshots
The patch enforces proper locking for this operation. Signed-off-by: Denis V. Lunev <den@openvz.org> Reviewed-by: Greg Kurz <gkurz@linux.vnet.ibm.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Fam Zheng <famz@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> CC: Kevin Wolf <kwolf@redhat.com> Tested-by: Greg Kurz <gkurz@linux.vnet.ibm.com> Signed-off-by: Juan Quintela <quintela@redhat.com>
This commit is contained in:
parent
5df5416e63
commit
e9ff957ac2
3 changed files with 36 additions and 13 deletions
|
@ -1958,19 +1958,10 @@ void hmp_savevm(Monitor *mon, const QDict *qdict)
|
|||
const char *name = qdict_get_try_str(qdict, "name");
|
||||
Error *local_err = NULL;
|
||||
|
||||
/* Verify if there is a device that doesn't support snapshots and is writable */
|
||||
bs = NULL;
|
||||
while ((bs = bdrv_next(bs))) {
|
||||
|
||||
if (!bdrv_is_inserted(bs) || bdrv_is_read_only(bs)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!bdrv_can_snapshot(bs)) {
|
||||
monitor_printf(mon, "Device '%s' is writable but does not support snapshots.\n",
|
||||
bdrv_get_device_name(bs));
|
||||
return;
|
||||
}
|
||||
if (!bdrv_all_can_snapshot(&bs)) {
|
||||
monitor_printf(mon, "Device '%s' is writable but does not "
|
||||
"support snapshots.\n", bdrv_get_device_name(bs));
|
||||
return;
|
||||
}
|
||||
|
||||
bs = find_vmstate_bs();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue