motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-01 06:43:53 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

rust: cleanup module_init!, use it from #[derive(Object)]

Browse source 
Remove the duplicate code by using the module_init! macro; at the same time,
simplify how module_init! is used, by taking inspiration from the implementation
of #[derive(Object)].

Reviewed-by: Junjie Mao <junjie.mao@hotmail.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2024-10-21 13:24:22 +02:00
parent cde3c425d1
commit e90d470733
2 changed files with 32 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

33
rust/qemu-api-macros/src/lib.rs
View file

@ -3,43 +3,20 @@
// SPDX-License-Identifier: GPL-2.0-or-later // SPDX-License-Identifier: GPL-2.0-or-later
use proc_macro::TokenStream; use proc_macro::TokenStream;
use quote::{format_ident, quote}; use quote::quote;
use syn::{parse_macro_input, DeriveInput}; use syn::{parse_macro_input, DeriveInput};
#[proc_macro_derive(Object)] #[proc_macro_derive(Object)]
pub fn derive_object(input: TokenStream) -> TokenStream { pub fn derive_object(input: TokenStream) -> TokenStream {
let input = parse_macro_input!(input as DeriveInput); let input = parse_macro_input!(input as DeriveInput);
let name = input.ident; let name = input.ident;
let module_static = format_ident!("__{}_LOAD_MODULE", name);
let expanded = quote! { let expanded = quote! {
#[allow(non_upper_case_globals)] ::qemu_api::module_init! {
#[used] MODULE_INIT_QOM => unsafe {
#[cfg_attr( ::qemu_api::bindings::type_register_static(&<#name as ::qemu_api::definitions::ObjectImpl>::TYPE_INFO);
not(any(target_vendor = "apple", target_os = "windows")),
link_section = ".init_array"
)]
#[cfg_attr(target_vendor = "apple", link_section = "__DATA,__mod_init_func")]
#[cfg_attr(target_os = "windows", link_section = ".CRT$XCU")]
pub static #module_static: extern "C" fn() = {
extern "C" fn __register() {
unsafe {
::qemu_api::bindings::type_register_static(&<#name as ::qemu_api::definitions::ObjectImpl>::TYPE_INFO);
}
} }
}
extern "C" fn __load() {
unsafe {
::qemu_api::bindings::register_module_init(
Some(__register),
::qemu_api::bindings::module_init_type::MODULE_INIT_QOM
);
}
}
__load
};
}; };
TokenStream::from(expanded) TokenStream::from(expanded)

65
rust/qemu-api/src/definitions.rs
View file

@ -29,51 +29,40 @@ pub trait Class {
#[macro_export] #[macro_export]
macro_rules! module_init { macro_rules! module_init {
($func:expr, $type:expr) => { ($type:ident => $body:block) => {
#[used] const _: () = {
#[cfg_attr( #[used]
not(any(target_vendor = "apple", target_os = "windows")), #[cfg_attr(
link_section = ".init_array" not(any(target_vendor = "apple", target_os = "windows")),
)] link_section = ".init_array"
#[cfg_attr(target_vendor = "apple", link_section = "__DATA,__mod_init_func")] )]
#[cfg_attr(target_os = "windows", link_section = ".CRT$XCU")] #[cfg_attr(target_vendor = "apple", link_section = "__DATA,__mod_init_func")]
pub static LOAD_MODULE: extern "C" fn() = { #[cfg_attr(target_os = "windows", link_section = ".CRT$XCU")]
extern "C" fn __load() { pub static LOAD_MODULE: extern "C" fn() = {
unsafe { extern "C" fn init_fn() {
$crate::bindings::register_module_init(Some($func), $type);
}
}
__load
};
};
(qom: $func:ident => $body:block) => {
// NOTE: To have custom identifiers for the ctor func we need to either supply
// them directly as a macro argument or create them with a proc macro.
#[used]
#[cfg_attr(
not(any(target_vendor = "apple", target_os = "windows")),
link_section = ".init_array"
)]
#[cfg_attr(target_vendor = "apple", link_section = "__DATA,__mod_init_func")]
#[cfg_attr(target_os = "windows", link_section = ".CRT$XCU")]
pub static LOAD_MODULE: extern "C" fn() = {
extern "C" fn __load() {
unsafe extern "C" fn $func() {
$body $body
} }
unsafe { extern "C" fn ctor_fn() {
$crate::bindings::register_module_init( unsafe {
Some($func), $crate::bindings::register_module_init(
$crate::bindings::module_init_type::MODULE_INIT_QOM, Some(init_fn),
); $crate::bindings::module_init_type::$type,
);
}
} }
}
__load ctor_fn
};
}; };
}; };
// shortcut because it's quite common that $body needs unsafe {}
($type:ident => unsafe $body:block) => {
$crate::module_init! {
$type => { unsafe { $body } }
}
};
} }
#[macro_export] #[macro_export]