core/register: Specify instance_size in the TypeInfo

Reported-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <4cf1beb7dafb9143c261d266557d3173bf160524.1598376594.git.alistair.francis@wdc.com>
This commit is contained in:
Alistair Francis 2020-08-20 15:46:11 -07:00
parent 617160c9e1
commit e8a612b7e3

View file

@ -176,17 +176,6 @@ void register_reset(RegisterInfo *reg)
} }
} }
void register_init(RegisterInfo *reg)
{
assert(reg);
if (!reg->data || !reg->access) {
return;
}
object_initialize((void *)reg, sizeof(*reg), TYPE_REGISTER);
}
void register_write_memory(void *opaque, hwaddr addr, void register_write_memory(void *opaque, hwaddr addr,
uint64_t value, unsigned size) uint64_t value, unsigned size)
{ {
@ -269,13 +258,18 @@ static RegisterInfoArray *register_init_block(DeviceState *owner,
int index = rae[i].addr / data_size; int index = rae[i].addr / data_size;
RegisterInfo *r = &ri[index]; RegisterInfo *r = &ri[index];
*r = (RegisterInfo) { if (data + data_size * index == 0 || !&rae[i]) {
.data = data + data_size * index, continue;
.data_size = data_size, }
.access = &rae[i],
.opaque = owner, /* Init the register, this will zero it. */
}; object_initialize((void *)r, sizeof(*r), TYPE_REGISTER);
register_init(r);
/* Set the properties of the register */
r->data = data + data_size * index;
r->data_size = data_size;
r->access = &rae[i];
r->opaque = owner;
r_array->r[i] = r; r_array->r[i] = r;
} }
@ -329,6 +323,7 @@ static const TypeInfo register_info = {
.name = TYPE_REGISTER, .name = TYPE_REGISTER,
.parent = TYPE_DEVICE, .parent = TYPE_DEVICE,
.class_init = register_class_init, .class_init = register_class_init,
.instance_size = sizeof(RegisterInfo),
}; };
static void register_register_types(void) static void register_register_types(void)