motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-01 14:53:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

util/log: Return bool from qemu_set_log_filename

Browse source 
Per the recommendations in qapi/error.h, return false on failure.

Use the return value in the monitor, the only place we aren't
already passing error_fatal or error_abort.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220417183019.755276-4-richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2022-04-17 11:29:43 -07:00
parent eecb0c4e11
commit e2c7c6a454
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
util/log.c
View file

@ -138,7 +138,7 @@ void qemu_set_log(int log_flags)
*
* filename may be NULL. In that case, log output is sent to stderr
*/
void qemu_set_log_filename(const char *filename, Error **errp)
bool qemu_set_log_filename(const char *filename, Error **errp)
{
g_free(logfilename);
logfilename = NULL;
@ -149,7 +149,7 @@ void qemu_set_log_filename(const char *filename, Error **errp)
/* We only accept one %d, no other format strings */
if (pidstr[1] != 'd' || strchr(pidstr + 2, '%')) {
error_setg(errp, "Bad logfile format: %s", filename);
return;
return false;
} else {
logfilename = g_strdup_printf(filename, getpid());
}
@ -160,6 +160,7 @@ void qemu_set_log_filename(const char *filename, Error **errp)
qemu_log_close();
qemu_set_log(qemu_loglevel);
return true;
}
/* Returns true if addr is in our debug filter or no filter defined