motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-06 09:13:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/char: riscv_htif: Drop useless assignment of memory region

Browse source 
struct HTIFState has 3 members for address space and memory region,
and are initialized during htif_mm_init(). But they are actually
useless. Drop them.

Signed-off-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20221229091828.1945072-4-bmeng@tinylab.org>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
This commit is contained in:
Bin Meng 2022-12-29 17:18:19 +08:00 • committed by Alistair Francis
parent bc9c3b1862
commit dc68824641
3 changed files with 6 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

7
include/hw/char/riscv_htif.h
View file

@ -34,9 +34,6 @@ typedef struct HTIFState {
hwaddr tohost_offset;
hwaddr fromhost_offset;
MemoryRegion mmio;
MemoryRegion *address_space;
MemoryRegion *main_mem;
void *main_mem_ram_ptr;
CPURISCVState *env;
CharBackend chr;
@ -54,7 +51,7 @@ void htif_symbol_callback(const char *st_name, int st_info, uint64_t st_value,
bool htif_uses_elf_symbols(void);
/* legacy pre qom */
HTIFState *htif_mm_init(MemoryRegion *address_space, MemoryRegion *main_mem,
CPURISCVState *env, Chardev *chr, uint64_t nonelf_base);
HTIFState *htif_mm_init(MemoryRegion *address_space, CPURISCVState *env,
Chardev *chr, uint64_t nonelf_base);
#endif