motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-17 07:02:03 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

multiboot: Check validity of mh_header_addr

Browse source 
I couldn't find a case where this prevents something bad from happening
that isn't already caught by other checks, but let's err on the safe
side and check that mh_header_addr is as expected.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Jack Schwartz <jack.schwartz@oracle.com>
This commit is contained in:
Kevin Wolf 2018-03-14 17:57:45 +01:00
parent b17a9054a0
commit dbf2dce7aa
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
hw/i386/multiboot.c
View file

@ -229,6 +229,10 @@ int load_multiboot(FWCfgState *fw_cfg,
error_report("invalid load_addr address"); error_report("invalid load_addr address");
exit(1); exit(1);
} }
if (mh_header_addr - mh_load_addr > i) {
error_report("invalid header_addr address");
exit(1);
}
uint32_t mb_kernel_text_offset = i - (mh_header_addr - mh_load_addr); uint32_t mb_kernel_text_offset = i - (mh_header_addr - mh_load_addr);
uint32_t mb_load_size = 0; uint32_t mb_load_size = 0;