motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-07-29 05:13:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests/functional: Fix hash validation

Browse source 
The _check() function is supposed to check whether the hash of the
downloaded file matches the expected one. Unfortunately, during the
last rework of this function, the check was accidentally turned into
returning the hash value itself instead of a True/False value,
effectively accepting each hash as valid. Let's do a proper check
again now.

Fixes:05e303210d ("tests/functional/qemu_test: Use Python hashlib ...")
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
Thomas Huth 2024-10-04 15:02:25 +02:00 • committed by Michael Tokarev
parent f2a9c31dbb
commit db17daf8c4
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/functional/qemu_test/asset.py
View file

@ -57,7 +57,7 @@ class Asset:
break break
hl.update(chunk) hl.update(chunk)
return hl.hexdigest() return self.hash == hl.hexdigest()
def valid(self): def valid(self):
return self.cache_file.exists() and self._check(self.cache_file) return self.cache_file.exists() and self._check(self.cache_file)