target/hppa: Use TCG_COND_TST* in do_cond

We can directly test bits of a 32-bit comparison without
zero or sign-extending an intermediate result.
We can directly test bit 0 for odd/even.

Reviewed-by: Helge Deller <deller@gmx.de>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2024-03-25 10:27:12 -10:00
parent 4c42fd0d4e
commit d6d46be1bf

View file

@ -776,28 +776,36 @@ static bool cond_need_cb(int c)
static DisasCond do_cond(DisasContext *ctx, unsigned cf, bool d, static DisasCond do_cond(DisasContext *ctx, unsigned cf, bool d,
TCGv_i64 res, TCGv_i64 uv, TCGv_i64 sv) TCGv_i64 res, TCGv_i64 uv, TCGv_i64 sv)
{ {
TCGCond sign_cond, zero_cond;
uint64_t sign_imm, zero_imm;
DisasCond cond; DisasCond cond;
TCGv_i64 tmp; TCGv_i64 tmp;
if (d) {
/* 64-bit condition. */
sign_imm = 0;
sign_cond = TCG_COND_LT;
zero_imm = 0;
zero_cond = TCG_COND_EQ;
} else {
/* 32-bit condition. */
sign_imm = 1ull << 31;
sign_cond = TCG_COND_TSTNE;
zero_imm = UINT32_MAX;
zero_cond = TCG_COND_TSTEQ;
}
switch (cf >> 1) { switch (cf >> 1) {
case 0: /* Never / TR (0 / 1) */ case 0: /* Never / TR (0 / 1) */
cond = cond_make_f(); cond = cond_make_f();
break; break;
case 1: /* = / <> (Z / !Z) */ case 1: /* = / <> (Z / !Z) */
if (!d) { cond = cond_make_vi(zero_cond, res, zero_imm);
tmp = tcg_temp_new_i64();
tcg_gen_ext32u_i64(tmp, res);
res = tmp;
}
cond = cond_make_vi(TCG_COND_EQ, res, 0);
break; break;
case 2: /* < / >= (N ^ V / !(N ^ V) */ case 2: /* < / >= (N ^ V / !(N ^ V) */
tmp = tcg_temp_new_i64(); tmp = tcg_temp_new_i64();
tcg_gen_xor_i64(tmp, res, sv); tcg_gen_xor_i64(tmp, res, sv);
if (!d) { cond = cond_make_ti(sign_cond, tmp, sign_imm);
tcg_gen_ext32s_i64(tmp, tmp);
}
cond = cond_make_ti(TCG_COND_LT, tmp, 0);
break; break;
case 3: /* <= / > (N ^ V) | Z / !((N ^ V) | Z) */ case 3: /* <= / > (N ^ V) | Z / !((N ^ V) | Z) */
/* /*
@ -805,21 +813,15 @@ static DisasCond do_cond(DisasContext *ctx, unsigned cf, bool d,
* (N ^ V) | Z * (N ^ V) | Z
* ((res < 0) ^ (sv < 0)) | !res * ((res < 0) ^ (sv < 0)) | !res
* ((res ^ sv) < 0) | !res * ((res ^ sv) < 0) | !res
* (~(res ^ sv) >= 0) | !res * ((res ^ sv) < 0 ? 1 : !res)
* !(~(res ^ sv) >> 31) | !res * !((res ^ sv) < 0 ? 0 : res)
* !(~(res ^ sv) >> 31 & res)
*/ */
tmp = tcg_temp_new_i64(); tmp = tcg_temp_new_i64();
tcg_gen_eqv_i64(tmp, res, sv); tcg_gen_xor_i64(tmp, res, sv);
if (!d) { tcg_gen_movcond_i64(sign_cond, tmp,
tcg_gen_sextract_i64(tmp, tmp, 31, 1); tmp, tcg_constant_i64(sign_imm),
tcg_gen_and_i64(tmp, tmp, res); ctx->zero, res);
tcg_gen_ext32u_i64(tmp, tmp); cond = cond_make_ti(zero_cond, tmp, zero_imm);
} else {
tcg_gen_sari_i64(tmp, tmp, 63);
tcg_gen_and_i64(tmp, tmp, res);
}
cond = cond_make_ti(TCG_COND_EQ, tmp, 0);
break; break;
case 4: /* NUV / UV (!UV / UV) */ case 4: /* NUV / UV (!UV / UV) */
cond = cond_make_vi(TCG_COND_EQ, uv, 0); cond = cond_make_vi(TCG_COND_EQ, uv, 0);
@ -827,23 +829,13 @@ static DisasCond do_cond(DisasContext *ctx, unsigned cf, bool d,
case 5: /* ZNV / VNZ (!UV | Z / UV & !Z) */ case 5: /* ZNV / VNZ (!UV | Z / UV & !Z) */
tmp = tcg_temp_new_i64(); tmp = tcg_temp_new_i64();
tcg_gen_movcond_i64(TCG_COND_EQ, tmp, uv, ctx->zero, ctx->zero, res); tcg_gen_movcond_i64(TCG_COND_EQ, tmp, uv, ctx->zero, ctx->zero, res);
if (!d) { cond = cond_make_ti(zero_cond, tmp, zero_imm);
tcg_gen_ext32u_i64(tmp, tmp);
}
cond = cond_make_ti(TCG_COND_EQ, tmp, 0);
break; break;
case 6: /* SV / NSV (V / !V) */ case 6: /* SV / NSV (V / !V) */
if (!d) { cond = cond_make_vi(sign_cond, sv, sign_imm);
tmp = tcg_temp_new_i64();
tcg_gen_ext32s_i64(tmp, sv);
sv = tmp;
}
cond = cond_make_ti(TCG_COND_LT, sv, 0);
break; break;
case 7: /* OD / EV */ case 7: /* OD / EV */
tmp = tcg_temp_new_i64(); cond = cond_make_vi(TCG_COND_TSTNE, res, 1);
tcg_gen_andi_i64(tmp, res, 1);
cond = cond_make_ti(TCG_COND_NE, tmp, 0);
break; break;
default: default:
g_assert_not_reached(); g_assert_not_reached();