motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-20 16:42:04 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

s390x/css: fix NULL handling for CCW addresses

Browse source 
Back then in the time of df1fe5bb49 ("s390: Virtual channel subsystem
support.", 2013-01-24) -EIO used to map to a channel-program check (via
the default label of the switch statement).  Then 2dc95b4cac
("s390x/3270: 3270 data stream handling", 2016-04-01) came along
and that changed dramatically.

Let us roll back this undesired side effect, and go back to
channel-program check.

Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Fixes: 2dc95b4cac "s390x/3270: 3270 data stream handling"
Message-Id: <20170908152446.14606-3-pasic@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
This commit is contained in:
Halil Pasic 2017-09-08 17:24:44 +02:00 • committed by Cornelia Huck
parent 248b920df9
commit cc6a9f8dc9
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hw/s390x/css.c
View file

@ -793,7 +793,7 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr ccw_addr,
CCW1 ccw; CCW1 ccw;
if (!ccw_addr) { if (!ccw_addr) {
return -EIO; return -EINVAL; /* channel-program check */
} }
/* Check doubleword aligned and 31 or 24 (fmt 0) bit addressable. */ /* Check doubleword aligned and 31 or 24 (fmt 0) bit addressable. */
if (ccw_addr & (sch->ccw_fmt_1 ? 0x80000007 : 0xff000007)) { if (ccw_addr & (sch->ccw_fmt_1 ? 0x80000007 : 0xff000007)) {