motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-08 02:03:56 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

qcow2: handle_copied(): Get rid of keep_clusters parameter

Browse source 
Now *bytes is used to return the length of the area that can be written
to without performing an allocation or COW.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Kevin Wolf 2013-03-26 17:50:07 +01:00 • committed by Stefan Hajnoczi
parent acb0467f8d
commit c53ede9f6d
1 changed files with 13 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

23
block/qcow2-cluster.c
View file

@ -831,19 +831,17 @@ static int handle_dependencies(BlockDriverState *bs, uint64_t guest_offset,
* *
* -errno: in error cases * -errno: in error cases
* *
* TODO Get rid of keep_clusters parameter
* TODO Make bytes behave like described above
* TODO Make non-zero host_offset behave like describe above * TODO Make non-zero host_offset behave like describe above
*/ */
static int handle_copied(BlockDriverState *bs, uint64_t guest_offset, static int handle_copied(BlockDriverState *bs, uint64_t guest_offset,
uint64_t *host_offset, uint64_t *bytes, QCowL2Meta **m, uint64_t *host_offset, uint64_t *bytes, QCowL2Meta **m)
unsigned int *keep_clusters)
{ {
BDRVQcowState *s = bs->opaque; BDRVQcowState *s = bs->opaque;
int l2_index; int l2_index;
uint64_t cluster_offset; uint64_t cluster_offset;
uint64_t *l2_table; uint64_t *l2_table;
unsigned int nb_clusters; unsigned int nb_clusters;
unsigned int keep_clusters;
int ret, pret; int ret, pret;
trace_qcow2_handle_copied(qemu_coroutine_self(), guest_offset, *host_offset, trace_qcow2_handle_copied(qemu_coroutine_self(), guest_offset, *host_offset,
@ -873,17 +871,19 @@ static int handle_copied(BlockDriverState *bs, uint64_t guest_offset,
&& (cluster_offset & QCOW_OFLAG_COPIED)) && (cluster_offset & QCOW_OFLAG_COPIED))
{ {
/* We keep all QCOW_OFLAG_COPIED clusters */ /* We keep all QCOW_OFLAG_COPIED clusters */
*keep_clusters = keep_clusters =
count_contiguous_clusters(nb_clusters, s->cluster_size, count_contiguous_clusters(nb_clusters, s->cluster_size,
&l2_table[l2_index], 0, &l2_table[l2_index], 0,
QCOW_OFLAG_COPIED | QCOW_OFLAG_ZERO); QCOW_OFLAG_COPIED | QCOW_OFLAG_ZERO);
assert(*keep_clusters <= nb_clusters); assert(keep_clusters <= nb_clusters);
*bytes = MIN(*bytes,
keep_clusters * s->cluster_size
- offset_into_cluster(s, guest_offset));
ret = 1; ret = 1;
} else { } else {
*keep_clusters = 0;
cluster_offset = 0; cluster_offset = 0;
ret = 0; ret = 0;
} }
@ -1168,16 +1168,19 @@ again:
* TODO: Consider cluster_offset if set in step 1c. * TODO: Consider cluster_offset if set in step 1c.
*/ */
uint64_t tmp_bytes = cur_bytes; uint64_t tmp_bytes = cur_bytes;
ret = handle_copied(bs, offset, &cluster_offset, &tmp_bytes, m, ret = handle_copied(bs, offset, &cluster_offset, &tmp_bytes, m);
&keep_clusters);
if (ret < 0) { if (ret < 0) {
return ret; return ret;
} else if (ret) { } else if (ret) {
keep_clusters =
size_to_clusters(s, tmp_bytes + offset_into_cluster(s, offset));
nb_clusters -= keep_clusters; nb_clusters -= keep_clusters;
if (!*host_offset) { if (!*host_offset) {
*host_offset = cluster_offset; *host_offset = cluster_offset;
} }
} else {
keep_clusters = 0;
} }
/* If there is something left to allocate, do that now */ /* If there is something left to allocate, do that now */