motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-07 09:43:56 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/net: Make NetCanReceive() return a boolean

Browse source 
The NetCanReceive handler return whether the device can or
can not receive new packets. Make it obvious by returning
a boolean type.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
This commit is contained in:
Philippe Mathieu-Daudé 2020-03-05 18:56:49 +01:00 • committed by Jason Wang
parent 3317db7439
commit b8c4b67e3e
20 changed files with 45 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

2
net/filter-buffer.c
View file

@ -74,7 +74,7 @@ static ssize_t filter_buffer_receive_iov(NetFilterState *nf,
* the filter can still accept packets until its internal queue is full.
* For example:
* For some reason, receiver could not receive more packets
* (.can_receive() returns zero). Without a filter, at most one packet
* (.can_receive() returns false). Without a filter, at most one packet
* will be queued in incoming queue and sender's poll will be disabled
* unit its sent_cb() was called. With a filter, it will keep receiving
* the packets without caring about the receiver. This is suboptimal.

6
net/hub.c
View file

@ -90,7 +90,7 @@ static NetHub *net_hub_new(int id)
return hub;
}
static int net_hub_port_can_receive(NetClientState *nc)
static bool net_hub_port_can_receive(NetClientState *nc)
{
NetHubPort *port;
NetHubPort *src_port = DO_UPCAST(NetHubPort, nc, nc);
@ -102,11 +102,11 @@ static int net_hub_port_can_receive(NetClientState *nc)
}
if (qemu_can_send_packet(&port->nc)) {
return 1;
return true;
}
}
return 0;
return false;
}
static ssize_t net_hub_port_receive(NetClientState *nc,