util/qemu-sockets: Refactor setting client sockopts into a separate function

This is done in preparation for enabling the SO_KEEPALIVE support for
server sockets and adding settings for more TCP keep-alive socket
options.

Signed-off-by: Juraj Marcin <jmarcin@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Juraj Marcin 2025-05-21 15:52:31 +02:00 committed by Daniel P. Berrangé
parent 0dc051aa85
commit b8b5278aca

View file

@ -205,6 +205,22 @@ static int try_bind(int socket, InetSocketAddress *saddr, struct addrinfo *e)
#endif
}
static int inet_set_sockopts(int sock, InetSocketAddress *saddr, Error **errp)
{
if (saddr->keep_alive) {
int keep_alive = 1;
int ret = setsockopt(sock, SOL_SOCKET, SO_KEEPALIVE,
&keep_alive, sizeof(keep_alive));
if (ret < 0) {
error_setg_errno(errp, errno,
"Unable to set keep-alive option on socket");
return -1;
}
}
return 0;
}
static int inet_listen_saddr(InetSocketAddress *saddr,
int port_offset,
int num,
@ -475,16 +491,9 @@ int inet_connect_saddr(InetSocketAddress *saddr, Error **errp)
return sock;
}
if (saddr->keep_alive) {
int val = 1;
int ret = setsockopt(sock, SOL_SOCKET, SO_KEEPALIVE,
&val, sizeof(val));
if (ret < 0) {
error_setg_errno(errp, errno, "Unable to set KEEPALIVE");
close(sock);
return -1;
}
if (inet_set_sockopts(sock, saddr, errp) < 0) {
close(sock);
return -1;
}
return sock;