motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-01 06:43:53 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

util/hexdump: Reorder qemu_hexdump() arguments

Browse source 
qemu_hexdump()'s pointer to the buffer and length of the
buffer are closely related arguments but are widely separated
in the argument list order (also, the format of <stdio.h>
function prototypes is usually to have the FILE* argument
coming first).

Reorder the arguments as "fp, prefix, buf, size" which is
more logical.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-Id: <20200822180950.1343963-3-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
Philippe Mathieu-Daudé 2020-08-22 20:09:50 +02:00 • committed by Laurent Vivier
parent 67263b33af
commit b42581f5bb
10 changed files with 23 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

4
include/qemu-common.h
View file

@ -138,8 +138,8 @@ int os_parse_cmd_args(int index, const char *optarg);
* Hexdump a buffer to a file. An optional string prefix is added to every line
*/
void qemu_hexdump(const void *bufptr, FILE *fp,
const char *prefix, size_t size);
void qemu_hexdump(FILE *fp, const char *prefix,
const void *bufptr, size_t size);
/*
* helper to parse debug environment variables