motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-06 01:03:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

util/hexdump: Reorder qemu_hexdump() arguments

Browse source 
qemu_hexdump()'s pointer to the buffer and length of the
buffer are closely related arguments but are widely separated
in the argument list order (also, the format of <stdio.h>
function prototypes is usually to have the FILE* argument
coming first).

Reorder the arguments as "fp, prefix, buf, size" which is
more logical.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-Id: <20200822180950.1343963-3-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
Philippe Mathieu-Daudé 2020-08-22 20:09:50 +02:00 • committed by Laurent Vivier
parent 67263b33af
commit b42581f5bb
10 changed files with 23 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hw/dma/xlnx_dpdma.c
View file

@ -388,7 +388,7 @@ static void xlnx_dpdma_dump_descriptor(DPDMADescriptor *desc)
{
if (DEBUG_DPDMA) {
qemu_log("DUMP DESCRIPTOR:\n");
qemu_hexdump(desc, stdout, "", sizeof(DPDMADescriptor));
qemu_hexdump(stdout, "", desc, sizeof(DPDMADescriptor));
}
}

2
hw/net/fsl_etsec/etsec.c
View file

@ -357,7 +357,7 @@ static ssize_t etsec_receive(NetClientState *nc,
#if defined(HEX_DUMP)
fprintf(stderr, "%s receive size:%zd\n", nc->name, size);
qemu_hexdump(buf, stderr, "", size);
qemu_hexdump(stderr, "", buf, size);
#endif
/* Flush is unnecessary as are already in receiving path */
etsec->need_flush = false;

2
hw/net/fsl_etsec/rings.c
View file

@ -269,7 +269,7 @@ static void process_tx_bd(eTSEC *etsec,
#if defined(HEX_DUMP)
qemu_log("eTSEC Send packet size:%d\n", etsec->tx_buffer_len);
qemu_hexdump(etsec->tx_buffer, stderr, "", etsec->tx_buffer_len);
qemu_hexdump(stderr, "", etsec->tx_buffer, etsec->tx_buffer_len);
#endif /* ETSEC_RING_DEBUG */
if (etsec->first_bd.flags & BD_TX_TOEUN) {

2
hw/sd/sd.c
View file

@ -1785,7 +1785,7 @@ send_response:
}
#ifdef DEBUG_SD
qemu_hexdump(response, stderr, "Response", rsplen);
qemu_hexdump(stderr, "Response", response, rsplen);
#endif
return rsplen;

2
hw/usb/redirect.c
View file

@ -240,7 +240,7 @@ static void usbredir_log_data(USBRedirDevice *dev, const char *desc,
if (dev->debug < usbredirparser_debug_data) {
return;
}
qemu_hexdump(data, stderr, desc, len);
qemu_hexdump(stderr, desc, data, len);
}
/*