mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-05 16:53:55 -06:00
hw/cxl: Line length reductions
Michael Tsirkin observed that there were some unnecessarily long lines in the CXL code in a recent review. This patch is intended to rectify that where it does not hurt readability. Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru> Reviewed-by: Fan Ni <fan.ni@samsung.com> Message-Id: <20231023140210.3089-5-Jonathan.Cameron@huawei.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
parent
b34ae3c906
commit
b342489ae7
9 changed files with 59 additions and 35 deletions
|
@ -175,7 +175,8 @@ HDM_DECODER_INIT(3);
|
|||
(CXL_IDE_REGISTERS_OFFSET + CXL_IDE_REGISTERS_SIZE)
|
||||
#define CXL_SNOOP_REGISTERS_SIZE 0x8
|
||||
|
||||
QEMU_BUILD_BUG_MSG((CXL_SNOOP_REGISTERS_OFFSET + CXL_SNOOP_REGISTERS_SIZE) >= 0x1000,
|
||||
QEMU_BUILD_BUG_MSG((CXL_SNOOP_REGISTERS_OFFSET +
|
||||
CXL_SNOOP_REGISTERS_SIZE) >= 0x1000,
|
||||
"No space for registers");
|
||||
|
||||
typedef struct component_registers {
|
||||
|
|
|
@ -192,7 +192,7 @@ void cxl_device_register_init_common(CXLDeviceState *dev);
|
|||
* Documented as a 128 bit register, but 64 bit accesses and the second
|
||||
* 64 bits are currently reserved.
|
||||
*/
|
||||
REG64(CXL_DEV_CAP_ARRAY, 0) /* Documented as 128 bit register but 64 byte accesses */
|
||||
REG64(CXL_DEV_CAP_ARRAY, 0)
|
||||
FIELD(CXL_DEV_CAP_ARRAY, CAP_ID, 0, 16)
|
||||
FIELD(CXL_DEV_CAP_ARRAY, CAP_VERSION, 16, 8)
|
||||
FIELD(CXL_DEV_CAP_ARRAY, CAP_COUNT, 32, 16)
|
||||
|
@ -361,7 +361,8 @@ struct CXLType3Class {
|
|||
uint64_t offset);
|
||||
void (*set_lsa)(CXLType3Dev *ct3d, const void *buf, uint64_t size,
|
||||
uint64_t offset);
|
||||
bool (*set_cacheline)(CXLType3Dev *ct3d, uint64_t dpa_offset, uint8_t *data);
|
||||
bool (*set_cacheline)(CXLType3Dev *ct3d, uint64_t dpa_offset,
|
||||
uint8_t *data);
|
||||
};
|
||||
|
||||
MemTxResult cxl_type3_read(PCIDevice *d, hwaddr host_addr, uint64_t *data,
|
||||
|
|
|
@ -92,7 +92,8 @@ typedef enum CXLEventIntMode {
|
|||
CXL_INT_RES = 0x03,
|
||||
} CXLEventIntMode;
|
||||
#define CXL_EVENT_INT_MODE_MASK 0x3
|
||||
#define CXL_EVENT_INT_SETTING(vector) ((((uint8_t)vector & 0xf) << 4) | CXL_INT_MSI_MSIX)
|
||||
#define CXL_EVENT_INT_SETTING(vector) \
|
||||
((((uint8_t)vector & 0xf) << 4) | CXL_INT_MSI_MSIX)
|
||||
typedef struct CXLEventInterruptPolicy {
|
||||
uint8_t info_settings;
|
||||
uint8_t warn_settings;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue