motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-30 13:31:52 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

s390x/pci: enhance mpcifc_service_call

Browse source 
Enhance error handling for mpcifc_service_call() to propagate errors
to guest by setting status codes or triggering program interrupts.

Signed-off-by: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
Reviewed-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
This commit is contained in:
Yi Min Zhao 2016-04-28 13:24:07 +08:00 • committed by Cornelia Huck
parent 259a4f0a76
commit a6d9d4f26a
2 changed files with 54 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

53
hw/s390x/s390-pci-inst.c
View file

@ -721,7 +721,7 @@ void pci_dereg_ioat(S390PCIBusDevice *pbdev)
int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar) int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar)
{ {
CPUS390XState *env = &cpu->env; CPUS390XState *env = &cpu->env;
uint8_t oc; uint8_t oc, dmaas;
uint32_t fh; uint32_t fh;
ZpciFib fib; ZpciFib fib;
S390PCIBusDevice *pbdev; S390PCIBusDevice *pbdev;
@ -733,6 +733,7 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar)
} }
oc = env->regs[r1] & 0xff; oc = env->regs[r1] & 0xff;
dmaas = (env->regs[r1] >> 16) & 0xff;
fh = env->regs[r1] >> 32; fh = env->regs[r1] >> 32;
if (fiba & 0x7) { if (fiba & 0x7) {
@ -751,27 +752,65 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar)
return 0; return 0;
} }
if (fib.fmt != 0) {
program_interrupt(env, PGM_OPERAND, 6);
return 0;
}
switch (oc) { switch (oc) {
case ZPCI_MOD_FC_REG_INT: case ZPCI_MOD_FC_REG_INT:
if (reg_irqs(env, pbdev, fib)) { if (pbdev->summary_ind) {
cc = ZPCI_PCI_LS_ERR; cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);
} else if (reg_irqs(env, pbdev, fib)) {
cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_RES_NOT_AVAIL);
} }
break; break;
case ZPCI_MOD_FC_DEREG_INT: case ZPCI_MOD_FC_DEREG_INT:
pci_dereg_irqs(pbdev); if (!pbdev->summary_ind) {
cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);
} else {
pci_dereg_irqs(pbdev);
}
break; break;
case ZPCI_MOD_FC_REG_IOAT: case ZPCI_MOD_FC_REG_IOAT:
if (reg_ioat(env, pbdev, fib)) { if (dmaas != 0) {
cc = ZPCI_PCI_LS_ERR; cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_DMAAS_INVAL);
} else if (pbdev->iommu_enabled) {
cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);
} else if (reg_ioat(env, pbdev, fib)) {
cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_INSUF_RES);
} }
break; break;
case ZPCI_MOD_FC_DEREG_IOAT: case ZPCI_MOD_FC_DEREG_IOAT:
pci_dereg_ioat(pbdev); if (dmaas != 0) {
cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_DMAAS_INVAL);
} else if (!pbdev->iommu_enabled) {
cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);
} else {
pci_dereg_ioat(pbdev);
}
break; break;
case ZPCI_MOD_FC_REREG_IOAT: case ZPCI_MOD_FC_REREG_IOAT:
pci_dereg_ioat(pbdev); if (dmaas != 0) {
if (reg_ioat(env, pbdev, fib)) {
cc = ZPCI_PCI_LS_ERR; cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_DMAAS_INVAL);
} else if (!pbdev->iommu_enabled) {
cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);
} else {
pci_dereg_ioat(pbdev);
if (reg_ioat(env, pbdev, fib)) {
cc = ZPCI_PCI_LS_ERR;
s390_set_status_code(env, r1, ZPCI_MOD_ST_INSUF_RES);
}
} }
break; break;
case ZPCI_MOD_FC_RESET_ERROR: case ZPCI_MOD_FC_RESET_ERROR:

8
hw/s390x/s390-pci-inst.h
View file

@ -231,6 +231,14 @@ typedef struct ClpReqRspQueryPciGrp {
#define ZPCI_PCI_LS_BUSY 2 #define ZPCI_PCI_LS_BUSY 2
#define ZPCI_PCI_LS_INVAL_HANDLE 3 #define ZPCI_PCI_LS_INVAL_HANDLE 3
/* Modify PCI status codes */
#define ZPCI_MOD_ST_RES_NOT_AVAIL 4
#define ZPCI_MOD_ST_INSUF_RES 16
#define ZPCI_MOD_ST_SEQUENCE 24
#define ZPCI_MOD_ST_DMAAS_INVAL 28
#define ZPCI_MOD_ST_FRAME_INVAL 32
#define ZPCI_MOD_ST_ERROR_RECOVER 40
/* Modify PCI Function Controls */ /* Modify PCI Function Controls */
#define ZPCI_MOD_FC_REG_INT 2 #define ZPCI_MOD_FC_REG_INT 2
#define ZPCI_MOD_FC_DEREG_INT 3 #define ZPCI_MOD_FC_DEREG_INT 3