qapi: Improve reporting of invalid flags

Split check_flags() off check_keys() and have check_exprs() call it
later, so its error messages gain an "in definition" line.  Tweak the
error messages.

Checking values in a function named check_keys() is unclean anyway.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190927134639.4284-20-armbru@redhat.com>
This commit is contained in:
Markus Armbruster 2019-09-27 15:46:32 +02:00
parent 576f0b8a53
commit a6735a5743
5 changed files with 20 additions and 14 deletions

View file

@ -1 +1,2 @@
tests/qapi-schema/allow-preconfig-test.json:2: 'allow-preconfig' of command 'allow-preconfig-test' should only use true value
tests/qapi-schema/allow-preconfig-test.json: In command 'allow-preconfig-test':
tests/qapi-schema/allow-preconfig-test.json:2: flag 'allow-preconfig' may only use true value

View file

@ -1 +1,2 @@
tests/qapi-schema/args-bad-boxed.json:2: 'boxed' of command 'foo' should only use true value
tests/qapi-schema/args-bad-boxed.json: In command 'foo':
tests/qapi-schema/args-bad-boxed.json:2: flag 'boxed' may only use true value

View file

@ -1 +1,2 @@
tests/qapi-schema/oob-test.json:2: 'allow-oob' of command 'oob-command-1' should only use true value
tests/qapi-schema/oob-test.json: In command 'oob-command-1':
tests/qapi-schema/oob-test.json:2: flag 'allow-oob' may only use true value

View file

@ -1 +1,2 @@
tests/qapi-schema/type-bypass-bad-gen.json:2: 'gen' of command 'foo' should only use false value
tests/qapi-schema/type-bypass-bad-gen.json: In command 'foo':
tests/qapi-schema/type-bypass-bad-gen.json:2: flag 'gen' may only use false value