motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-04 16:23:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

qapi: Fix crash on missing enum member name

Browse source 
New test case enum-dict-no-name.json crashes:

    $ python3 scripts/qapi-gen.py tests/qapi-schema/enum-dict-no-name.json
    Traceback (most recent call last):
    [...]
      File "/work/armbru/qemu/scripts/qapi/expr.py", line 458, in check_enum
	member_name = member['name']
    KeyError: 'name'

Root cause: we try to retrieve member 'name' before we check for
missing members.  With that fixed, we get the expected error "'data'
member misses key 'name'".

Fixes: 0825f62c84
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210616072121.626431-1-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
This commit is contained in:
Markus Armbruster 2021-06-16 09:21:21 +02:00
parent a9649a719a
commit a0c7b99bf7
4 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/qapi-schema/enum-dict-no-name.err Normal file
View file

@ -0,0 +1,2 @@
enum-dict-no-name.json: In enum 'Enum':
enum-dict-no-name.json:2: 'data' member misses key 'name'