mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-05 08:43:55 -06:00
ppc/{ppc440_bamboo, sam460ex}: drop RAM size fixup
If user provided non-sense RAM size, board will complain and continue running with max RAM size supported or sometimes crash like this: %QEMU -M bamboo -m 1 exec.c:1926: find_ram_offset: Assertion `size != 0' failed. Aborted (core dumped) Also RAM is going to be allocated by generic code, so it won't be possible for board to fix things up for user. Make it error message and exit to force user fix CLI, instead of accepting non-sense CLI values. That also fixes crash issue, since wrongly calculated size isn't used to allocate RAM Signed-off-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> Acked-by: David Gibson <david@gibson.dropbear.id.au> Message-Id: <20200219160953.13771-66-imammedo@redhat.com>
This commit is contained in:
parent
2dc9ce13d2
commit
a0258e4afa
4 changed files with 42 additions and 43 deletions
|
@ -324,9 +324,8 @@ static void sam460ex_init(MachineState *machine)
|
|||
/* SDRAM controller */
|
||||
/* put all RAM on first bank because board has one slot
|
||||
* and firmware only checks that */
|
||||
machine->ram_size = ppc4xx_sdram_adjust(machine->ram_size, 1,
|
||||
ram_memories, ram_bases, ram_sizes,
|
||||
ppc460ex_sdram_bank_sizes);
|
||||
ppc4xx_sdram_banks(machine->ram_size, 1, ram_memories, ram_bases, ram_sizes,
|
||||
ppc460ex_sdram_bank_sizes);
|
||||
|
||||
/* FIXME: does 460EX have ECC interrupts? */
|
||||
ppc440_sdram_init(env, SDRAM_NR_BANKS, ram_memories,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue