mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-07 09:43:56 -06:00
coccinelle: Remove unnecessary variables for function return value
Use Coccinelle script to replace 'ret = E; return ret' with 'return E'. The script will do the substitution only when the function return type and variable type are the same. Manual fixups: * audio/audio.c: coding style of "read (...)" and "write (...)" * block/qcow2-cluster.c: wrap line to make it shorter * block/qcow2-refcount.c: change indentation of wrapped line * target-tricore/op_helper.c: fix coding style of "remainder|quotient" * target-mips/dsp_helper.c: reverted changes because I don't want to argue about checkpatch.pl * ui/qemu-pixman.c: fix line indentation * block/rbd.c: restore blank line between declarations and statements Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <1465855078-19435-4-git-send-email-ehabkost@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> [Unused Coccinelle rule name dropped along with a redundant comment; whitespace touched up in block/qcow2-cluster.c; stale commit message paragraph deleted] Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
parent
6b62d96137
commit
9be385980d
45 changed files with 88 additions and 228 deletions
19
scripts/coccinelle/return_directly.cocci
Normal file
19
scripts/coccinelle/return_directly.cocci
Normal file
|
@ -0,0 +1,19 @@
|
|||
// replace 'R = X; return R;' with 'return R;'
|
||||
@@
|
||||
identifier VAR;
|
||||
expression E;
|
||||
type T;
|
||||
identifier F;
|
||||
@@
|
||||
T F(...)
|
||||
{
|
||||
...
|
||||
- T VAR;
|
||||
... when != VAR
|
||||
|
||||
- VAR =
|
||||
+ return
|
||||
E;
|
||||
- return VAR;
|
||||
... when != VAR
|
||||
}
|
Loading…
Add table
Add a link
Reference in a new issue