motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-05 00:33:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

replay: do not build if TCG is not available

Browse source 
this fixes non-TCG builds broken recently by replay reverse debugging.

Stub the needed functions in stub/, splitting roughly between functions
needed only by system emulation, by system emulation and tools,
and by everyone.  This includes duplicating some code in replay/, and
puts the logic for non-replay related events in the replay/ module (+
the stubs), so this should be revisited in the future.

Surprisingly, only _one_ qtest was affected by this, ide-test.c, which
resulted in a buzz as the bh events were never delivered, and the bh
never executed.

Many other subsystems _should_ have been affected.

This fixes the immediate issue, however a better way to group replay
functionality to TCG-only code could be developed in the long term.

Signed-off-by: Claudio Fontana <cfontana@suse.de>
Message-Id: <20201013192123.22632-4-cfontana@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Claudio Fontana 2020-10-13 21:21:23 +02:00 • committed by Paolo Bonzini
parent c51a5a23d8
commit 9b1c911654
10 changed files with 191 additions and 97 deletions
Download patch file Download diff file Expand all files Collapse all files

78
stubs/replay.c
View file

@ -3,83 +3,10 @@
ReplayMode replay_mode;
int64_t replay_save_clock(unsigned int kind, int64_t clock, int64_t raw_icount)
{
abort();
return 0;
}
int64_t replay_read_clock(unsigned int kind)
{
abort();
return 0;
}
bool replay_checkpoint(ReplayCheckpoint checkpoint)
{
return true;
}
bool replay_events_enabled(void)
{
return false;
}
void replay_finish(void)
{
}
void replay_register_char_driver(Chardev *chr)
{
}
void replay_chr_be_write(Chardev *s, uint8_t *buf, int len)
{
abort();
}
void replay_char_write_event_save(int res, int offset)
{
abort();
}
void replay_char_write_event_load(int *res, int *offset)
{
abort();
}
int replay_char_read_all_load(uint8_t *buf)
{
abort();
}
void replay_char_read_all_save_error(int res)
{
abort();
}
void replay_char_read_all_save_buf(uint8_t *buf, int offset)
{
abort();
}
void replay_block_event(QEMUBH *bh, uint64_t id)
{
}
uint64_t blkreplay_next_id(void)
{
return 0;
}
void replay_mutex_lock(void)
{
}
void replay_mutex_unlock(void)
{
}
void replay_save_random(int ret, void *buf, size_t len)
{
}
@ -89,11 +16,6 @@ int replay_read_random(void *buf, size_t len)
return 0;
}
uint64_t replay_get_current_icount(void)
{
return 0;
}
bool replay_reverse_step(void)
{
return false;