motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-05 00:33:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

x86/cpuid: Plug memory leak in cpudef_setfield()

Browse source 
To reproduce the leak, put two name options into the same [cpudef]
section of target-x86_64.conf.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
This commit is contained in:
Markus Armbruster 2011-11-08 15:36:49 +01:00 • committed by Stefan Hajnoczi
parent d3c481b357
commit 99e1dec06f
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
target-i386/cpuid.c
View file

@ -950,6 +950,7 @@ static int cpudef_setfield(const char *name, const char *str, void *opaque)
int err = 0; int err = 0;
if (!strcmp(name, "name")) { if (!strcmp(name, "name")) {
g_free((void *)def->name);
def->name = g_strdup(str); def->name = g_strdup(str);
} else if (!strcmp(name, "model_id")) { } else if (!strcmp(name, "model_id")) {
strncpy(def->model_id, str, sizeof (def->model_id)); strncpy(def->model_id, str, sizeof (def->model_id));