motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-09-02 15:02:02 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

util/coroutine: Cleanup start_switch_fiber_ for TSAN.

Browse source 
This is a cleanup patch to follow-up the patch which introduced TSAN.
This patch makes separate start_switch_fiber_ functions for TSAN and ASAN.

This does two things:
1. Unrelated ASAN and TSAN code is separate and each function only
   has arguments that are actually needed.
2. The co->tsan_caller_fiber and co->tsan_co_fiber fields are only
   access from within #ifdef CONFIG_TSAN.

Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200626170001.27017-1-robert.foley@linaro.org>
Message-Id: <20200701135652.1366-5-alex.bennee@linaro.org>
This commit is contained in:
Robert Foley 2020-07-01 14:56:16 +01:00 • committed by Alex Bennée
parent b418d26561
commit 995f5c3c32
1 changed files with 34 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

52
util/coroutine-ucontext.c
View file

@ -52,8 +52,10 @@ typedef struct {
#endif #endif
sigjmp_buf env; sigjmp_buf env;
#ifdef CONFIG_TSAN
void *tsan_co_fiber; void *tsan_co_fiber;
void *tsan_caller_fiber; void *tsan_caller_fiber;
#endif
#ifdef CONFIG_VALGRIND_H #ifdef CONFIG_VALGRIND_H
unsigned int valgrind_stack_id; unsigned int valgrind_stack_id;
@ -77,7 +79,10 @@ union cc_arg {
int i[2]; int i[2];
}; };
/* QEMU_ALWAYS_INLINE only does so if __OPTIMIZE__, so we cannot use it. */ /*
* QEMU_ALWAYS_INLINE only does so if __OPTIMIZE__, so we cannot use it.
* always_inline is required to avoid TSan runtime fatal errors.
*/
static inline __attribute__((always_inline)) static inline __attribute__((always_inline))
void on_new_fiber(CoroutineUContext *co) void on_new_fiber(CoroutineUContext *co)
{ {
@ -87,6 +92,7 @@ void on_new_fiber(CoroutineUContext *co)
#endif #endif
} }
/* always_inline is required to avoid TSan runtime fatal errors. */
static inline __attribute__((always_inline)) static inline __attribute__((always_inline))
void finish_switch_fiber(void *fake_stack_save) void finish_switch_fiber(void *fake_stack_save)
{ {
@ -109,18 +115,29 @@ void finish_switch_fiber(void *fake_stack_save)
#endif #endif
} }
static inline __attribute__((always_inline)) void start_switch_fiber( /* always_inline is required to avoid TSan runtime fatal errors. */
CoroutineAction action, void **fake_stack_save, static inline __attribute__((always_inline))
const void *bottom, size_t size, void *new_fiber) void start_switch_fiber_asan(CoroutineAction action, void **fake_stack_save,
const void *bottom, size_t size)
{ {
#ifdef CONFIG_ASAN #ifdef CONFIG_ASAN
__sanitizer_start_switch_fiber( __sanitizer_start_switch_fiber(
action == COROUTINE_TERMINATE ? NULL : fake_stack_save, action == COROUTINE_TERMINATE ? NULL : fake_stack_save,
bottom, size); bottom, size);
#endif #endif
}
/* always_inline is required to avoid TSan runtime fatal errors. */
static inline __attribute__((always_inline))
void start_switch_fiber_tsan(void **fake_stack_save,
CoroutineUContext *co,
bool caller)
{
#ifdef CONFIG_TSAN #ifdef CONFIG_TSAN
void *curr_fiber = void *new_fiber = caller ?
__tsan_get_current_fiber(); co->tsan_caller_fiber :
co->tsan_co_fiber;
void *curr_fiber = __tsan_get_current_fiber();
__tsan_acquire(curr_fiber); __tsan_acquire(curr_fiber);
*fake_stack_save = curr_fiber; *fake_stack_save = curr_fiber;
@ -144,12 +161,9 @@ static void coroutine_trampoline(int i0, int i1)
/* Initialize longjmp environment and switch back the caller */ /* Initialize longjmp environment and switch back the caller */
if (!sigsetjmp(self->env, 0)) { if (!sigsetjmp(self->env, 0)) {
start_switch_fiber( start_switch_fiber_asan(COROUTINE_YIELD, &fake_stack_save, leader.stack,
COROUTINE_YIELD, leader.stack_size);
&fake_stack_save, start_switch_fiber_tsan(&fake_stack_save, self, true); /* true=caller */
leader.stack,
leader.stack_size,
self->tsan_caller_fiber);
siglongjmp(*(sigjmp_buf *)co->entry_arg, 1); siglongjmp(*(sigjmp_buf *)co->entry_arg, 1);
} }
@ -208,10 +222,10 @@ Coroutine *qemu_coroutine_new(void)
/* swapcontext() in, siglongjmp() back out */ /* swapcontext() in, siglongjmp() back out */
if (!sigsetjmp(old_env, 0)) { if (!sigsetjmp(old_env, 0)) {
start_switch_fiber( start_switch_fiber_asan(COROUTINE_YIELD, &fake_stack_save, co->stack,
COROUTINE_YIELD, co->stack_size);
&fake_stack_save, start_switch_fiber_tsan(&fake_stack_save,
co->stack, co->stack_size, co->tsan_co_fiber); co, false); /* false=not caller */
#ifdef CONFIG_SAFESTACK #ifdef CONFIG_SAFESTACK
/* /*
@ -287,8 +301,10 @@ qemu_coroutine_switch(Coroutine *from_, Coroutine *to_,
ret = sigsetjmp(from->env, 0); ret = sigsetjmp(from->env, 0);
if (ret == 0) { if (ret == 0) {
start_switch_fiber(action, &fake_stack_save, start_switch_fiber_asan(action, &fake_stack_save, to->stack,
to->stack, to->stack_size, to->tsan_co_fiber); to->stack_size);
start_switch_fiber_tsan(&fake_stack_save,
to, false); /* false=not caller */
siglongjmp(to->env, action); siglongjmp(to->env, action);
} }