motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-11 03:24:58 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

ivshmem: remove superflous ivshmem_attr field

Browse source 
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Claudio Fontana <claudio.fontana@huawei.com>
This commit is contained in:
Marc-André Lureau 2015-06-18 16:24:33 +02:00
parent dee2151e72
commit 9113e3f394
1 changed files with 7 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

16
hw/misc/ivshmem.c
View file

@ -85,7 +85,6 @@ typedef struct IVShmemState {
MemoryRegion bar; MemoryRegion bar;
MemoryRegion ivshmem; MemoryRegion ivshmem;
uint64_t ivshmem_size; /* size of shared memory region */ uint64_t ivshmem_size; /* size of shared memory region */
uint32_t ivshmem_attr;
uint32_t ivshmem_64bit; uint32_t ivshmem_64bit;
int shm_fd; /* shared memory file descriptor */ int shm_fd; /* shared memory file descriptor */
@ -345,7 +344,7 @@ static int check_shm_size(IVShmemState *s, int fd) {
/* create the shared memory BAR when we are not using the server, so we can /* create the shared memory BAR when we are not using the server, so we can
* create the BAR and map the memory immediately */ * create the BAR and map the memory immediately */
static void create_shared_memory_BAR(IVShmemState *s, int fd) { static void create_shared_memory_BAR(IVShmemState *s, int fd, uint8_t attr) {
void * ptr; void * ptr;
@ -359,7 +358,7 @@ static void create_shared_memory_BAR(IVShmemState *s, int fd) {
memory_region_add_subregion(&s->bar, 0, &s->ivshmem); memory_region_add_subregion(&s->bar, 0, &s->ivshmem);
/* region for shared memory */ /* region for shared memory */
pci_register_bar(PCI_DEVICE(s), 2, s->ivshmem_attr, &s->bar); pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar);
} }
static void ivshmem_add_eventfd(IVShmemState *s, int posn, int i) static void ivshmem_add_eventfd(IVShmemState *s, int posn, int i)
@ -714,6 +713,8 @@ static int pci_ivshmem_init(PCIDevice *dev)
{ {
IVShmemState *s = IVSHMEM(dev); IVShmemState *s = IVSHMEM(dev);
uint8_t *pci_conf; uint8_t *pci_conf;
uint8_t attr = PCI_BASE_ADDRESS_SPACE_MEMORY |
PCI_BASE_ADDRESS_MEM_PREFETCH;
if (s->sizearg == NULL) if (s->sizearg == NULL)
s->ivshmem_size = 4 << 20; /* 4 MB default */ s->ivshmem_size = 4 << 20; /* 4 MB default */
@ -768,10 +769,8 @@ static int pci_ivshmem_init(PCIDevice *dev)
&s->ivshmem_mmio); &s->ivshmem_mmio);
memory_region_init(&s->bar, OBJECT(s), "ivshmem-bar2-container", s->ivshmem_size); memory_region_init(&s->bar, OBJECT(s), "ivshmem-bar2-container", s->ivshmem_size);
s->ivshmem_attr = PCI_BASE_ADDRESS_SPACE_MEMORY |
PCI_BASE_ADDRESS_MEM_PREFETCH;
if (s->ivshmem_64bit) { if (s->ivshmem_64bit) {
s->ivshmem_attr |= PCI_BASE_ADDRESS_MEM_TYPE_64; attr |= PCI_BASE_ADDRESS_MEM_TYPE_64;
} }
if ((s->server_chr != NULL) && if ((s->server_chr != NULL) &&
@ -798,7 +797,7 @@ static int pci_ivshmem_init(PCIDevice *dev)
/* allocate/initialize space for interrupt handling */ /* allocate/initialize space for interrupt handling */
s->peers = g_malloc0(s->nb_peers * sizeof(Peer)); s->peers = g_malloc0(s->nb_peers * sizeof(Peer));
pci_register_bar(dev, 2, s->ivshmem_attr, &s->bar); pci_register_bar(dev, 2, attr, &s->bar);
s->eventfd_chr = g_malloc0(s->vectors * sizeof(CharDriverState *)); s->eventfd_chr = g_malloc0(s->vectors * sizeof(CharDriverState *));
@ -835,8 +834,7 @@ static int pci_ivshmem_init(PCIDevice *dev)
exit(1); exit(1);
} }
create_shared_memory_BAR(s, fd); create_shared_memory_BAR(s, fd, attr);
} }
dev->config_write = ivshmem_write_config; dev->config_write = ivshmem_write_config;