motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-05 08:43:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/i2c: Introduce i2c_start_recv() and i2c_start_send()

Browse source 
To ease reviewing code using the I2C bus API, introduce the
i2c_start_recv() and i2c_start_send() helpers which don't
take the confusing 'is_recv' boolean argument.

Use these new helpers in the SMBus / AUX bus models.

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
This commit is contained in:
Philippe Mathieu-Daudé 2021-06-17 13:53:34 +02:00 • committed by Corey Minyard
parent 265caf45c6
commit 90603c5b89
5 changed files with 53 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

12
hw/misc/auxbus.c
View file

@ -135,7 +135,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address,
i2c_end_transfer(i2c_bus);
}
if (i2c_start_transfer(i2c_bus, address, true)) {
if (i2c_start_recv(i2c_bus, address)) {
ret = AUX_I2C_NACK;
break;
}
@ -151,7 +151,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address,
i2c_end_transfer(i2c_bus);
}
if (i2c_start_transfer(i2c_bus, address, false)) {
if (i2c_start_send(i2c_bus, address)) {
ret = AUX_I2C_NACK;
break;
}
@ -179,7 +179,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address,
/*
* No transactions started..
*/
if (i2c_start_transfer(i2c_bus, address, false)) {
if (i2c_start_send(i2c_bus, address)) {
break;
}
} else if ((address != bus->last_i2c_address) ||
@ -188,7 +188,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address,
* Transaction started but we need to restart..
*/
i2c_end_transfer(i2c_bus);
if (i2c_start_transfer(i2c_bus, address, false)) {
if (i2c_start_send(i2c_bus, address)) {
break;
}
}
@ -210,7 +210,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address,
/*
* No transactions started..
*/
if (i2c_start_transfer(i2c_bus, address, true)) {
if (i2c_start_recv(i2c_bus, address)) {
break;
}
} else if ((address != bus->last_i2c_address) ||
@ -219,7 +219,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address,
* Transaction started but we need to restart..
*/
i2c_end_transfer(i2c_bus);
if (i2c_start_transfer(i2c_bus, address, true)) {
if (i2c_start_recv(i2c_bus, address)) {
break;
}
}