motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-18 07:32:06 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/virtio/vhost-backend: Fix Coverity CID 1432871

Browse source 
Fix uninitialized value issues reported by Coverity:

  Field 'msg.reserved' is uninitialized when calling write().

While the 'struct vhost_msg' does not have a 'reserved' field,
we still initialize it to have the two parts of the function
consistent.

Reported-by: Coverity (CID 1432864: UNINIT)
Fixes: c471ad0e9b ("vhost_net: device IOTLB support")
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201103063541.2463363-1-philmd@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Philippe Mathieu-Daudé 2020-11-03 07:35:41 +01:00 • committed by Michael S. Tsirkin
parent 510feed79a
commit 8faf2f1de4
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
hw/virtio/vhost-backend.c
View file

@ -257,7 +257,7 @@ static int vhost_kernel_send_device_iotlb_msg(struct vhost_dev *dev,
struct vhost_iotlb_msg *imsg) struct vhost_iotlb_msg *imsg)
{ {
if (dev->backend_cap & (1ULL << VHOST_BACKEND_F_IOTLB_MSG_V2)) { if (dev->backend_cap & (1ULL << VHOST_BACKEND_F_IOTLB_MSG_V2)) {
struct vhost_msg_v2 msg; struct vhost_msg_v2 msg = {};
msg.type = VHOST_IOTLB_MSG_V2; msg.type = VHOST_IOTLB_MSG_V2;
msg.iotlb = *imsg; msg.iotlb = *imsg;
@ -267,7 +267,7 @@ static int vhost_kernel_send_device_iotlb_msg(struct vhost_dev *dev,
return -EFAULT; return -EFAULT;
} }
} else { } else {
struct vhost_msg msg; struct vhost_msg msg = {};
msg.type = VHOST_IOTLB_MSG; msg.type = VHOST_IOTLB_MSG;
msg.iotlb = *imsg; msg.iotlb = *imsg;