hw/xen/hvm: Propagate page_mask to a pair of functions

We are going to replace TARGET_PAGE_MASK by a
runtime variable. In order to reduce code duplication,
propagate TARGET_PAGE_MASK to get_physmapping() and
xen_phys_offset_to_gaddr().

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-Id: <20231114163123.74888-3-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2023-11-14 15:53:26 +01:00
parent 62d6cf9d63
commit 8ebb8682f6

View file

@ -174,11 +174,12 @@ static void xen_ram_init(PCMachineState *pcms,
} }
} }
static XenPhysmap *get_physmapping(hwaddr start_addr, ram_addr_t size) static XenPhysmap *get_physmapping(hwaddr start_addr, ram_addr_t size,
int page_mask)
{ {
XenPhysmap *physmap = NULL; XenPhysmap *physmap = NULL;
start_addr &= TARGET_PAGE_MASK; start_addr &= page_mask;
QLIST_FOREACH(physmap, &xen_physmap, list) { QLIST_FOREACH(physmap, &xen_physmap, list) {
if (range_covers_byte(physmap->start_addr, physmap->size, start_addr)) { if (range_covers_byte(physmap->start_addr, physmap->size, start_addr)) {
@ -188,9 +189,10 @@ static XenPhysmap *get_physmapping(hwaddr start_addr, ram_addr_t size)
return NULL; return NULL;
} }
static hwaddr xen_phys_offset_to_gaddr(hwaddr phys_offset, ram_addr_t size) static hwaddr xen_phys_offset_to_gaddr(hwaddr phys_offset, ram_addr_t size,
int page_mask)
{ {
hwaddr addr = phys_offset & TARGET_PAGE_MASK; hwaddr addr = phys_offset & page_mask;
XenPhysmap *physmap = NULL; XenPhysmap *physmap = NULL;
QLIST_FOREACH(physmap, &xen_physmap, list) { QLIST_FOREACH(physmap, &xen_physmap, list) {
@ -252,7 +254,7 @@ static int xen_add_to_physmap(XenIOState *state,
hwaddr phys_offset = memory_region_get_ram_addr(mr); hwaddr phys_offset = memory_region_get_ram_addr(mr);
const char *mr_name; const char *mr_name;
if (get_physmapping(start_addr, size)) { if (get_physmapping(start_addr, size, TARGET_PAGE_MASK)) {
return 0; return 0;
} }
if (size <= 0) { if (size <= 0) {
@ -325,7 +327,7 @@ static int xen_remove_from_physmap(XenIOState *state,
XenPhysmap *physmap = NULL; XenPhysmap *physmap = NULL;
hwaddr phys_offset = 0; hwaddr phys_offset = 0;
physmap = get_physmapping(start_addr, size); physmap = get_physmapping(start_addr, size, TARGET_PAGE_MASK);
if (physmap == NULL) { if (physmap == NULL) {
return -1; return -1;
} }
@ -373,7 +375,7 @@ static void xen_sync_dirty_bitmap(XenIOState *state,
int rc, i, j; int rc, i, j;
const XenPhysmap *physmap = NULL; const XenPhysmap *physmap = NULL;
physmap = get_physmapping(start_addr, size); physmap = get_physmapping(start_addr, size, TARGET_PAGE_MASK);
if (physmap == NULL) { if (physmap == NULL) {
/* not handled */ /* not handled */
return; return;
@ -633,7 +635,7 @@ void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length)
int rc; int rc;
ram_addr_t start_pfn, nb_pages; ram_addr_t start_pfn, nb_pages;
start = xen_phys_offset_to_gaddr(start, length); start = xen_phys_offset_to_gaddr(start, length, TARGET_PAGE_MASK);
if (length == 0) { if (length == 0) {
length = TARGET_PAGE_SIZE; length = TARGET_PAGE_SIZE;