mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-07-27 12:23:53 -06:00
iotests: Use Python byte strings where appropriate
Since byte strings are no longer the default in Python 3, we have to explicitly use them where we need to, which is mostly when working with structures. It also means that we need to open a file in binary mode when we want to use structures. On the other hand, we have to accomodate for the fact that some functions (still) work with byte strings but we want to use unicode strings (in Python 3 at least, and it does not matter in Python 2). This includes base64 encoding, but it is most notable when working with the subprocess module: Either we set universal_newlines to True so that the default streams are opened in text mode (hence this parameter is aliased as "text" as of 3.7), or, if that is not possible, we have to decode the output to a normal string. Signed-off-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20181022135307.14398-4-mreitz@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
parent
f544adf736
commit
8eb5e6746f
7 changed files with 26 additions and 21 deletions
|
@ -64,7 +64,7 @@ class QEMUQtestProtocol(object):
|
|||
|
||||
@param qtest_cmd: qtest command text to be sent
|
||||
"""
|
||||
self._sock.sendall(qtest_cmd + "\n")
|
||||
self._sock.sendall((qtest_cmd + "\n").encode('utf-8'))
|
||||
|
||||
def close(self):
|
||||
self._sock.close()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue