motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-18 07:32:06 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

net/slirp: fix leaks on forwarding rule registration error

Browse source 
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
This commit is contained in:
Marc-André Lureau 2019-01-17 15:43:36 +04:00 • committed by Samuel Thibault
parent 8d45a3b946
commit 8e207c327c
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
net/slirp.c
View file

@ -807,6 +807,7 @@ static int slirp_guestfwd(SlirpState *s, const char *config_str, Error **errp)
qemu_chr_fe_init(&fwd->hd, chr, &err); qemu_chr_fe_init(&fwd->hd, chr, &err);
if (err) { if (err) {
error_propagate(errp, err); error_propagate(errp, err);
object_unparent(OBJECT(chr));
g_free(fwd); g_free(fwd);
return -1; return -1;
} }
@ -815,6 +816,7 @@ static int slirp_guestfwd(SlirpState *s, const char *config_str, Error **errp)
&server, port) < 0) { &server, port) < 0) {
error_setg(errp, "Conflicting/invalid host:port in guest " error_setg(errp, "Conflicting/invalid host:port in guest "
"forwarding rule '%s'", config_str); "forwarding rule '%s'", config_str);
qemu_chr_fe_deinit(&fwd->hd, true);
g_free(fwd); g_free(fwd);
return -1; return -1;
} }