motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-04 00:03:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

qemu-ga: Add interface to traverse the qmp command list by QmpCommand

Browse source 
In the original code, qmp_get_command_list is used to construct
a list of all commands' name. To get the information of all qga
commands, it traverses the name list and search the command info
with its name.  So it can cause O(n^2) in the number of commands.

This patch adds an interface to traverse the qmp command list by
QmpCommand to replace qmp_get_command_list. It can decrease the
complexity from O(n^2) to O(n).

Signed-off-by: Mark Wu <wudxw@linux.vnet.ibm.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
*fix up commit subject
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
Mark Wu 2013-10-09 11:25:07 +08:00 • committed by Michael Roth
parent e5d9adbdab
commit 8dc4d915dd
4 changed files with 61 additions and 96 deletions
Download patch file Download diff file Expand all files Collapse all files

38
qapi/qmp-registry.c
View file

@ -66,35 +66,21 @@ void qmp_enable_command(const char *name)
qmp_toggle_command(name, true);
}
bool qmp_command_is_enabled(const char *name)
bool qmp_command_is_enabled(const QmpCommand *cmd)
{
return cmd->enabled;
}
const char *qmp_command_name(const QmpCommand *cmd)
{
return cmd->name;
}
void qmp_for_each_command(qmp_cmd_callback_fn fn, void *opaque)
{
QmpCommand *cmd;
QTAILQ_FOREACH(cmd, &qmp_commands, node) {
if (strcmp(cmd->name, name) == 0) {
return cmd->enabled;
}
fn(cmd, opaque);
}
return false;
}
char **qmp_get_command_list(void)
{
QmpCommand *cmd;
int count = 1;
char **list_head, **list;
QTAILQ_FOREACH(cmd, &qmp_commands, node) {
count++;
}
list_head = list = g_malloc0(count * sizeof(char *));
QTAILQ_FOREACH(cmd, &qmp_commands, node) {
*list = g_strdup(cmd->name);
list++;
}
return list_head;
}