motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-08 10:13:56 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

iotests: Drop use of bash keyword 'function'

Browse source 
Bash allows functions to be declared with or without the leading
keyword 'function'; but including the keyword does not comply with
POSIX syntax, and is confusing to ksh users where the use of the
keyword changes the scoping rules for functions.  Stick to the
POSIX form through iotests.

Done mechanically with:
  sed -i 's/^function //' $(git ls-files tests/qemu-iotests)

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20181116215002.2124581-1-eblake@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
This commit is contained in:
Eric Blake 2018-11-16 15:50:02 -06:00
parent bb39c47d70
commit 8cedcffdc1
35 changed files with 86 additions and 86 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/qemu-iotests/common.nbd
View file

@ -23,7 +23,7 @@ nbd_unix_socket="${TEST_DIR}/qemu-nbd.sock"
nbd_tcp_addr="127.0.0.1"
nbd_pid_file="${TEST_DIR}/qemu-nbd.pid"
function nbd_server_stop()
nbd_server_stop()
{
local NBD_PID
if [ -f "$nbd_pid_file" ]; then
@ -36,7 +36,7 @@ function nbd_server_stop()
rm -f "$nbd_unix_socket"
}
function nbd_server_wait_for_unix_socket()
nbd_server_wait_for_unix_socket()
{
pid=$1
@ -57,14 +57,14 @@ function nbd_server_wait_for_unix_socket()
exit 1
}
function nbd_server_start_unix_socket()
nbd_server_start_unix_socket()
{
nbd_server_stop
$QEMU_NBD -v -t -k "$nbd_unix_socket" "$@" &
nbd_server_wait_for_unix_socket $!
}
function nbd_server_set_tcp_port()
nbd_server_set_tcp_port()
{
(ss --help) >/dev/null 2>&1 || _notrun "ss utility not found, skipping test"
@ -80,7 +80,7 @@ function nbd_server_set_tcp_port()
exit 1
}
function nbd_server_wait_for_tcp_socket()
nbd_server_wait_for_tcp_socket()
{
pid=$1
@ -101,7 +101,7 @@ function nbd_server_wait_for_tcp_socket()
exit 1
}
function nbd_server_start_tcp_socket()
nbd_server_start_tcp_socket()
{
nbd_server_stop
$QEMU_NBD -v -t -b $nbd_tcp_addr -p $nbd_tcp_port "$@" &