motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-04 00:03:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

monitor: remove unused do_info_trace

Browse source 
Going forward with simpletrace v2 variable size trace records, we cannot
have a generic function to print trace event info and therefore this
interface becomes invalid.

As per Stefan Hajnoczi:

"This command is only available from the human monitor.  It's not very
useful because it historically hasn't been able to pretty-print events
or show them in the right order (we use a ringbuffer but it prints
them out from index 0).

Therefore, I don't think we're under any obligation to keep this
command around.  No one has complained about it's limitations - I
think this is a sign that no one has used it.  I'd be okay with a
patch that removes it."

Ref: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01268.html

Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
This commit is contained in:
Harsh Prateek Bora 2012-07-18 15:15:58 +05:30 • committed by Stefan Hajnoczi
parent 794b1f962e
commit 88affa1c77
3 changed files with 0 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

16
monitor.c
View file

@ -941,13 +941,6 @@ static void do_info_cpu_stats(Monitor *mon)
}
#endif
#if defined(CONFIG_TRACE_SIMPLE)
static void do_info_trace(Monitor *mon)
{
st_print_trace((FILE *)mon, &monitor_fprintf);
}
#endif
static void do_trace_print_events(Monitor *mon)
{
trace_print_events((FILE *)mon, &monitor_fprintf);
@ -2689,15 +2682,6 @@ static mon_cmd_t info_cmds[] = {
.help = "show roms",
.mhandler.info = do_info_roms,
},
#if defined(CONFIG_TRACE_SIMPLE)
{
.name = "trace",
.args_type = "",
.params = "",
.help = "show current contents of trace buffer",
.mhandler.info = do_info_trace,
},
#endif
{
.name = "trace-events",
.args_type = "",