motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-21 09:02:00 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

vmdk: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper

Browse source 
.bdrv_co_create implementations run in a coroutine. Therefore they are
not allowed to open images directly. Fix the calls to use the
corresponding no_co_wrappers instead.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230126172432.436111-11-kwolf@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Kevin Wolf 2023-01-26 18:24:29 +01:00
parent 41e089cbe9
commit 882f202e9d
1 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

16
block/vmdk.c
View file

@ -2299,7 +2299,7 @@ static int coroutine_fn vmdk_create_extent(const char *filename,
goto exit; goto exit;
} }
blk = blk_new_open(filename, NULL, NULL, blk = blk_co_new_open(filename, NULL, NULL,
BDRV_O_RDWR | BDRV_O_RESIZE | BDRV_O_PROTOCOL, BDRV_O_RDWR | BDRV_O_RESIZE | BDRV_O_PROTOCOL,
errp); errp);
if (blk == NULL) { if (blk == NULL) {
@ -2518,7 +2518,7 @@ static int coroutine_fn vmdk_co_do_create(int64_t size,
} }
assert(full_backing); assert(full_backing);
backing = blk_new_open(full_backing, NULL, NULL, backing = blk_co_new_open(full_backing, NULL, NULL,
BDRV_O_NO_BACKING, errp); BDRV_O_NO_BACKING, errp);
g_free(full_backing); g_free(full_backing);
if (backing == NULL) { if (backing == NULL) {
@ -2781,7 +2781,7 @@ static BlockBackend * coroutine_fn vmdk_co_create_cb(int64_t size, int idx,
BlockdevCreateOptionsVmdk *opts = opaque; BlockdevCreateOptionsVmdk *opts = opaque;
if (idx == 0) { if (idx == 0) {
bs = bdrv_open_blockdev_ref(opts->file, errp); bs = bdrv_co_open_blockdev_ref(opts->file, errp);
} else { } else {
int i; int i;
BlockdevRefList *list = opts->extents; BlockdevRefList *list = opts->extents;
@ -2796,14 +2796,16 @@ static BlockBackend * coroutine_fn vmdk_co_create_cb(int64_t size, int idx,
error_setg(errp, "Extent [%d] not specified", idx - 1); error_setg(errp, "Extent [%d] not specified", idx - 1);
return NULL; return NULL;
} }
bs = bdrv_open_blockdev_ref(list->value, errp); bs = bdrv_co_open_blockdev_ref(list->value, errp);
} }
if (!bs) { if (!bs) {
return NULL; return NULL;
} }
blk = blk_new_with_bs(bs, blk = blk_co_new_with_bs(bs,
BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE | BLK_PERM_RESIZE, BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE |
BLK_PERM_ALL, errp); BLK_PERM_RESIZE,
BLK_PERM_ALL,
errp);
if (!blk) { if (!blk) {
return NULL; return NULL;
} }