motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-21 09:02:00 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

rust: pl011: clean up visibilities of callbacks

Browse source 
Do not make callbacks unnecessarily "pub", they are only used
through function pointers.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2025-02-11 13:31:38 +01:00
parent 959fd759a2
commit 87f5c13836
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
rust/hw/char/pl011/src/device.rs
View file

@ -537,7 +537,7 @@ impl PL011State {
} }
} }
pub fn read(&self, offset: hwaddr, _size: u32) -> u64 { fn read(&self, offset: hwaddr, _size: u32) -> u64 {
match RegisterOffset::try_from(offset) { match RegisterOffset::try_from(offset) {
Err(v) if (0x3f8..0x400).contains(&(v >> 2)) => { Err(v) if (0x3f8..0x400).contains(&(v >> 2)) => {
let device_id = self.get_class().device_id; let device_id = self.get_class().device_id;
@ -560,7 +560,7 @@ impl PL011State {
} }
} }
pub fn write(&self, offset: hwaddr, value: u64, _size: u32) { fn write(&self, offset: hwaddr, value: u64, _size: u32) {
let mut update_irq = false; let mut update_irq = false;
if let Ok(field) = RegisterOffset::try_from(offset) { if let Ok(field) = RegisterOffset::try_from(offset) {
// qemu_chr_fe_write_all() calls into the can_receive // qemu_chr_fe_write_all() calls into the can_receive
@ -621,7 +621,7 @@ impl PL011State {
} }
} }
pub fn realize(&self) { fn realize(&self) {
// SAFETY: self.char_backend has the correct size and alignment for a // SAFETY: self.char_backend has the correct size and alignment for a
// CharBackend object, and its callbacks are of the correct types. // CharBackend object, and its callbacks are of the correct types.
unsafe { unsafe {
@ -638,11 +638,11 @@ impl PL011State {
} }
} }
pub fn reset_hold(&self, _type: ResetType) { fn reset_hold(&self, _type: ResetType) {
self.regs.borrow_mut().reset(); self.regs.borrow_mut().reset();
} }
pub fn update(&self) { fn update(&self) {
let regs = self.regs.borrow(); let regs = self.regs.borrow();
let flags = regs.int_level & regs.int_enabled; let flags = regs.int_level & regs.int_enabled;
for (irq, i) in self.interrupts.iter().zip(IRQMASK) { for (irq, i) in self.interrupts.iter().zip(IRQMASK) {