motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-16 14:41:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/i386/x86: Don't leak "pc.bios" memory region

Browse source 
Fix the leaking in x86_bios_rom_init() by adding a "bios" attribute to
X86MachineState. Note that it is only used in the -bios case.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Message-ID: <20240508175507.22270-5-shentey@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Bernhard Beschow 2024-05-08 19:55:05 +02:00 • committed by Philippe Mathieu-Daudé
parent 32d3ee87a1
commit 865d95321f
2 changed files with 12 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
hw/i386/x86.c
View file

@ -1133,7 +1133,6 @@ void x86_bios_rom_init(X86MachineState *x86ms, const char *default_firmware,
{ {
const char *bios_name; const char *bios_name;
char *filename; char *filename;
MemoryRegion *bios;
int bios_size, isa_bios_size; int bios_size, isa_bios_size;
ssize_t ret; ssize_t ret;
@ -1149,8 +1148,8 @@ void x86_bios_rom_init(X86MachineState *x86ms, const char *default_firmware,
(bios_size % 65536) != 0) { (bios_size % 65536) != 0) {
goto bios_error; goto bios_error;
} }
bios = g_malloc(sizeof(*bios)); memory_region_init_ram(&x86ms->bios, NULL, "pc.bios", bios_size,
memory_region_init_ram(bios, NULL, "pc.bios", bios_size, &error_fatal); &error_fatal);
if (sev_enabled()) { if (sev_enabled()) {
/* /*
* The concept of a "reset" simply doesn't exist for * The concept of a "reset" simply doesn't exist for
@ -1159,11 +1158,11 @@ void x86_bios_rom_init(X86MachineState *x86ms, const char *default_firmware,
* the firmware as rom to properly re-initialize on reset. * the firmware as rom to properly re-initialize on reset.
* Just go for a straight file load instead. * Just go for a straight file load instead.
*/ */
void *ptr = memory_region_get_ram_ptr(bios); void *ptr = memory_region_get_ram_ptr(&x86ms->bios);
load_image_size(filename, ptr, bios_size); load_image_size(filename, ptr, bios_size);
x86_firmware_configure(ptr, bios_size); x86_firmware_configure(ptr, bios_size);
} else { } else {
memory_region_set_readonly(bios, !isapc_ram_fw); memory_region_set_readonly(&x86ms->bios, !isapc_ram_fw);
ret = rom_add_file_fixed(bios_name, (uint32_t)(-bios_size), -1); ret = rom_add_file_fixed(bios_name, (uint32_t)(-bios_size), -1);
if (ret != 0) { if (ret != 0) {
goto bios_error; goto bios_error;
@ -1173,7 +1172,7 @@ void x86_bios_rom_init(X86MachineState *x86ms, const char *default_firmware,
/* map the last 128KB of the BIOS in ISA space */ /* map the last 128KB of the BIOS in ISA space */
isa_bios_size = MIN(bios_size, 128 * KiB); isa_bios_size = MIN(bios_size, 128 * KiB);
memory_region_init_alias(&x86ms->isa_bios, NULL, "isa-bios", bios, memory_region_init_alias(&x86ms->isa_bios, NULL, "isa-bios", &x86ms->bios,
bios_size - isa_bios_size, isa_bios_size); bios_size - isa_bios_size, isa_bios_size);
memory_region_add_subregion_overlap(rom_memory, memory_region_add_subregion_overlap(rom_memory,
0x100000 - isa_bios_size, 0x100000 - isa_bios_size,
@ -1184,7 +1183,7 @@ void x86_bios_rom_init(X86MachineState *x86ms, const char *default_firmware,
/* map all the bios at the top of memory */ /* map all the bios at the top of memory */
memory_region_add_subregion(rom_memory, memory_region_add_subregion(rom_memory,
(uint32_t)(-bios_size), (uint32_t)(-bios_size),
bios); &x86ms->bios);
return; return;
bios_error: bios_error:

6
include/hw/i386/x86.h
View file

@ -53,6 +53,12 @@ struct X86MachineState {
GMappedFile *initrd_mapped_file; GMappedFile *initrd_mapped_file;
HotplugHandler *acpi_dev; HotplugHandler *acpi_dev;
/*
* Map the whole BIOS just underneath the 4 GiB address boundary. Only used
* in the ROM (-bios) case.
*/
MemoryRegion bios;
/* /*
* Map the upper 128 KiB of the BIOS just underneath the 1 MiB address * Map the upper 128 KiB of the BIOS just underneath the 1 MiB address
* boundary. * boundary.