mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-07-28 21:03:54 -06:00
json: Pass lexical errors and limit violations to callback
The callback to consume JSON values takes QObject *json, Error *err. If both are null, the callback is supposed to make up an error by itself. This sucks. qjson.c's consume_json() neglects to do so, which makes qobject_from_json() null instead of failing. I consider that a bug. The culprit is json_message_process_token(): it passes two null pointers when it runs into a lexical error or a limit violation. Fix it to pass a proper Error object then. Update the callbacks: * monitor.c's handle_qmp_command(): the code to make up an error is now dead, drop it. * qga/main.c's process_event(): lumps the "both null" case together with the "not a JSON object" case. The former is now gone. The error message "Invalid JSON syntax" is misleading for the latter. Improve it to "Input must be a JSON object". * qobject/qjson.c's consume_json(): no update; check-qjson demonstrates qobject_from_json() now sets an error on lexical errors, but still doesn't on some other errors. * tests/libqtest.c's qmp_response(): the Error object is now reliable, so use it to improve the error message. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-Id: <20180823164025.12553-40-armbru@redhat.com>
This commit is contained in:
parent
2cbd15aa6f
commit
84a56f38b2
7 changed files with 33 additions and 25 deletions
|
@ -61,9 +61,6 @@
|
|||
#define QERR_IO_ERROR \
|
||||
"An IO error has occurred"
|
||||
|
||||
#define QERR_JSON_PARSING \
|
||||
"Invalid JSON syntax"
|
||||
|
||||
#define QERR_MIGRATION_ACTIVE \
|
||||
"There's a migration process in progress"
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue