motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-30 05:21:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests/unit/test-smp-parse: Use CPU number macros in invalid topology case

Browse source 
Use MAX_CPUS/MIN_CPUS macros in invalid topology case. This gives us the
flexibility to change the maximum and minimum CPU limits.

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Tested-by: Xiaoling Song <xiaoling.song@intel.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20240308160148.3130837-6-zhao1.liu@linux.intel.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Zhao Liu 2024-03-09 00:01:40 +08:00 • committed by Philippe Mathieu-Daudé
parent a4f9386071
commit 803f9714bf
1 changed files with 14 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

22
tests/unit/test-smp-parse.c
View file

@ -323,15 +323,21 @@ static const struct SMPTestData data_generic_invalid[] = {
"sockets (2) * cores (4) * threads (2) " "sockets (2) * cores (4) * threads (2) "
"== maxcpus (16) < smp_cpus (18)", "== maxcpus (16) < smp_cpus (18)",
}, { }, {
/* config: -smp 1 /*
* should tweak the supported min CPUs to 2 for testing */ * config: -smp 1
.config = SMP_CONFIG_GENERIC(T, 1, F, 0, F, 0, F, 0, F, 0), * The test machine should tweak the supported min CPUs to
* 2 (MIN_CPUS + 1) for testing.
*/
.config = SMP_CONFIG_GENERIC(T, MIN_CPUS, F, 0, F, 0, F, 0, F, 0),
.expect_error = "Invalid SMP CPUs 1. The min CPUs supported " .expect_error = "Invalid SMP CPUs 1. The min CPUs supported "
"by machine '" SMP_MACHINE_NAME "' is 2", "by machine '" SMP_MACHINE_NAME "' is 2",
}, { }, {
/* config: -smp 512 /*
* should tweak the supported max CPUs to 511 for testing */ * config: -smp 512
.config = SMP_CONFIG_GENERIC(T, 512, F, 0, F, 0, F, 0, F, 0), * The test machine should tweak the supported max CPUs to
* 511 (MAX_CPUS - 1) for testing.
*/
.config = SMP_CONFIG_GENERIC(T, MAX_CPUS, F, 0, F, 0, F, 0, F, 0),
.expect_error = "Invalid SMP CPUs 512. The max CPUs supported " .expect_error = "Invalid SMP CPUs 512. The max CPUs supported "
"by machine '" SMP_MACHINE_NAME "' is 511", "by machine '" SMP_MACHINE_NAME "' is 511",
}, },
@ -575,8 +581,8 @@ static void machine_generic_invalid_class_init(ObjectClass *oc, void *data)
MachineClass *mc = MACHINE_CLASS(oc); MachineClass *mc = MACHINE_CLASS(oc);
/* Force invalid min CPUs and max CPUs */ /* Force invalid min CPUs and max CPUs */
mc->min_cpus = 2; mc->min_cpus = MIN_CPUS + 1;
mc->max_cpus = 511; mc->max_cpus = MAX_CPUS - 1;
} }
static void machine_with_dies_class_init(ObjectClass *oc, void *data) static void machine_with_dies_class_init(ObjectClass *oc, void *data)