motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-03 07:43:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

qom: Drop object_property_set_description() parameter @errp

Browse source 
object_property_set_description() and
object_class_property_set_description() fail only when property @name
is not found.

There are 85 calls of object_property_set_description() and
object_class_property_set_description().  None of them can fail:

* 84 immediately follow the creation of the property.

* The one in spapr_rng_instance_init() refers to a property created in
  spapr_rng_class_init(), from spapr_rng_properties[].

Every one of them still gets to decide what to pass for @errp.

51 calls pass &error_abort, 32 calls pass NULL, one receives the error
and propagates it to &error_abort, and one propagates it to
&error_fatal.  I'm actually surprised none of them violates the Error
API.

What are we gaining by letting callers handle the "property not found"
error?  Use when the property is not known to exist is simpler: you
don't have to guard the call with a check.  We haven't found such a
use in 5+ years.  Until we do, let's make life a bit simpler and drop
the @errp parameter.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-8-armbru@redhat.com>
[One semantic rebase conflict resolved]
This commit is contained in:
Markus Armbruster 2020-05-05 17:29:15 +02:00
parent 7025188772
commit 7eecec7d12
30 changed files with 92 additions and 145 deletions
Download patch file Download diff file Expand all files Collapse all files

6
hw/core/qdev.c
View file

@ -775,8 +775,7 @@ void qdev_property_add_static(DeviceState *dev, Property *prop)
prop, &error_abort);
object_property_set_description(obj, prop->name,
prop->info->description,
&error_abort);
prop->info->description);
if (prop->set_default) {
prop->info->set_default_value(op, prop);
@ -805,8 +804,7 @@ static void qdev_class_add_property(DeviceClass *klass, Property *prop)
}
}
object_class_property_set_description(oc, prop->name,
prop->info->description,
&error_abort);
prop->info->description);
}
/* @qdev_alias_all_properties - Add alias properties to the source object for