motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-02 15:23:53 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

linux-user/elfload.c: Don't memset(NULL..) if malloc() failed

Browse source 
If a malloc() in copy_elf_strings() failed we would call memset()
before the "did malloc fail?" check. Fix this by moving to the
glib alloc/free routines for this memory so we can use g_try_malloc0
rather than having a separate memset(). Spotted by Coverity (see
bug 887883).

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Peter Maydell 2011-11-09 19:22:11 +00:00 • committed by Anthony Liguori
parent 096685fc2a
commit 7dd47667b9
2 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
linux-user/linuxload.c
View file

@ -178,7 +178,7 @@ int loader_exec(const char * filename, char ** argv, char ** envp,
/* Something went wrong, return the inode and free the argument pages*/
for (i=0 ; i<MAX_ARG_PAGES ; i++) {
free(bprm->page[i]);
g_free(bprm->page[i]);
}
return(retval);
}