motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-15 22:21:57 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

target-arm: Handle UNDEF cases for Neon invalid modified-immediates

Browse source 
For Neon "one register and a modified immediate value" forms, the
combination op=1 cmode=1111 is unallocated and should UNDEF.
All instructions of this form also UNDEF if Q == 1 and Vd<0> == 1.
We also add a comment on the only UNPREDICTABLE in this space.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
This commit is contained in:
Peter Maydell 2011-04-11 16:26:16 +01:00 • committed by Aurelien Jarno
parent 2bc70834e8
commit 7d80fee5b9
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
target-arm/translate.c
View file

@ -5084,11 +5084,18 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
} }
} else { /* (insn & 0x00380080) == 0 */ } else { /* (insn & 0x00380080) == 0 */
int invert; int invert;
if (q && (rd & 1)) {
return 1;
}
op = (insn >> 8) & 0xf; op = (insn >> 8) & 0xf;
/* One register and immediate. */ /* One register and immediate. */
imm = (u << 7) | ((insn >> 12) & 0x70) | (insn & 0xf); imm = (u << 7) | ((insn >> 12) & 0x70) | (insn & 0xf);
invert = (insn & (1 << 5)) != 0; invert = (insn & (1 << 5)) != 0;
/* Note that op = 2,3,4,5,6,7,10,11,12,13 imm=0 is UNPREDICTABLE.
* We choose to not special-case this and will behave as if a
* valid constant encoding of 0 had been given.
*/
switch (op) { switch (op) {
case 0: case 1: case 0: case 1:
/* no-op */ /* no-op */
@ -5120,6 +5127,9 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
imm = ~imm; imm = ~imm;
break; break;
case 15: case 15:
if (invert) {
return 1;
}
imm = ((imm & 0x80) << 24) | ((imm & 0x3f) << 19) imm = ((imm & 0x80) << 24) | ((imm & 0x3f) << 19)
| ((imm & 0x40) ? (0x1f << 25) : (1 << 30)); | ((imm & 0x40) ? (0x1f << 25) : (1 << 30));
break; break;