motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-09-08 16:07:39 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

qmp.py: Avoid overriding a builtin object

Browse source 
The "id" is a builtin method to get object's identity and should not be
overridden. This might bring some issues in case someone was directly
calling "cmd(..., id=id)" but I haven't found such usage on brief search
for "cmd\(.*id=".

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170818142613.32394-10-ldoktor@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Lukáš Doktor 2017-08-18 16:26:12 +02:00 • committed by Eduardo Habkost
parent 2cb05a3f36
commit 7b6b9dbb3c
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
scripts/qmp/qmp.py
View file

@ -177,19 +177,19 @@ class QEMUMonitorProtocol(object):
print >>sys.stderr, "QMP:<<< %s" % resp print >>sys.stderr, "QMP:<<< %s" % resp
return resp return resp
def cmd(self, name, args=None, id=None): def cmd(self, name, args=None, cmd_id=None):
""" """
Build a QMP command and send it to the QMP Monitor. Build a QMP command and send it to the QMP Monitor.
@param name: command name (string) @param name: command name (string)
@param args: command arguments (dict) @param args: command arguments (dict)
@param id: command id (dict, list, string or int) @param cmd_id: command id (dict, list, string or int)
""" """
qmp_cmd = {'execute': name} qmp_cmd = {'execute': name}
if args: if args:
qmp_cmd['arguments'] = args qmp_cmd['arguments'] = args
if id: if cmd_id:
qmp_cmd['id'] = id qmp_cmd['id'] = cmd_id
return self.cmd_obj(qmp_cmd) return self.cmd_obj(qmp_cmd)
def command(self, cmd, **kwds): def command(self, cmd, **kwds):