mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-07 17:53:56 -06:00
omap: Fix warnings from Sparse
Sparse report: arm/omap1.c:1015:9: warning: returning void-valued expression arm/omap1.c:1084:9: warning: returning void-valued expression arm/omap1.c:1178:9: warning: returning void-valued expression arm/omap1.c:1287:9: warning: returning void-valued expression arm/omap1.c:1382:9: warning: returning void-valued expression arm/omap1.c:1650:9: warning: returning void-valued expression arm/omap1.c:1778:9: warning: returning void-valued expression arm/omap1.c:1985:9: warning: returning void-valued expression arm/omap1.c:210:9: warning: returning void-valued expression arm/omap1.c:2213:9: warning: returning void-valued expression arm/omap1.c:2352:9: warning: returning void-valued expression arm/omap1.c:2447:9: warning: returning void-valued expression arm/omap1.c:2640:9: warning: returning void-valued expression arm/omap1.c:317:9: warning: returning void-valued expression arm/omap1.c:3413:13: warning: returning void-valued expression arm/omap1.c:3414:13: warning: returning void-valued expression arm/omap1.c:3415:14: warning: returning void-valued expression arm/omap1.c:3589:9: warning: returning void-valued expression arm/omap1.c:443:9: warning: returning void-valued expression arm/omap1.c:588:9: warning: returning void-valued expression arm/omap1.c:860:9: warning: returning void-valued expression arm/omap2.c:1362:9: warning: returning void-valued expression arm/omap2.c:450:9: warning: returning void-valued expression arm/omap2.c:695:9: warning: returning void-valued expression arm/omap2.c:760:9: warning: returning void-valued expression hw/char/omap_uart.c:115:9: warning: returning void-valued expression hw/display/omap_dss.c:1019:9: warning: returning void-valued expression hw/display/omap_dss.c:215:9: warning: returning void-valued expression hw/display/omap_dss.c:380:9: warning: returning void-valued expression hw/display/omap_dss.c:739:9: warning: returning void-valued expression hw/display/omap_dss.c:931:9: warning: returning void-valued expression hw/dma/omap_dma.c:139:5: warning: returning void-valued expression hw/dma/omap_dma.c:1505:9: warning: returning void-valued expression hw/dma/omap_dma.c:1860:9: warning: returning void-valued expression hw/gpio/omap_gpio.c:116:9: warning: returning void-valued expression hw/misc/omap_gpmc.c:627:9: warning: returning void-valued expression hw/misc/omap_l4.c:85:9: warning: returning void-valued expression hw/misc/omap_sdrc.c:95:9: warning: returning void-valued expression hw/misc/omap_tap.c:98:9: warning: returning void-valued expression hw/sd/omap_mmc.c:409:9: warning: returning void-valued expression hw/ssi/omap_spi.c:229:9: warning: returning void-valued expression hw/timer/omap_gptimer.c:447:9: warning: returning void-valued expression Cc: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Stefan Weil <sw@weilnetz.de> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
Stefan Weil
Michael Tokarev
parent
0289a412e8
commit
77a8257ed7
13 changed files with 84 additions and 42 deletions
|
|
@ -207,7 +207,8 @@ static void omap_mpu_timer_write(void *opaque, hwaddr addr,
|
|||
struct omap_mpu_timer_s *s = (struct omap_mpu_timer_s *) opaque;
|
||||
|
||||
if (size != 4) {
|
||||
return omap_badwidth_write32(opaque, addr, value);
|
||||
omap_badwidth_write32(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
@ -314,7 +315,8 @@ static void omap_wd_timer_write(void *opaque, hwaddr addr,
|
|||
struct omap_watchdog_timer_s *s = (struct omap_watchdog_timer_s *) opaque;
|
||||
|
||||
if (size != 2) {
|
||||
return omap_badwidth_write16(opaque, addr, value);
|
||||
omap_badwidth_write16(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
@ -440,7 +442,8 @@ static void omap_os_timer_write(void *opaque, hwaddr addr,
|
|||
int offset = addr & OMAP_MPUI_REG_MASK;
|
||||
|
||||
if (size != 4) {
|
||||
return omap_badwidth_write32(opaque, addr, value);
|
||||
omap_badwidth_write32(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (offset) {
|
||||
|
|
@ -585,7 +588,8 @@ static void omap_ulpd_pm_write(void *opaque, hwaddr addr,
|
|||
uint16_t diff;
|
||||
|
||||
if (size != 2) {
|
||||
return omap_badwidth_write16(opaque, addr, value);
|
||||
omap_badwidth_write16(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
@ -857,7 +861,8 @@ static void omap_pin_cfg_write(void *opaque, hwaddr addr,
|
|||
uint32_t diff;
|
||||
|
||||
if (size != 4) {
|
||||
return omap_badwidth_write32(opaque, addr, value);
|
||||
omap_badwidth_write32(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
@ -1012,7 +1017,8 @@ static void omap_id_write(void *opaque, hwaddr addr,
|
|||
uint64_t value, unsigned size)
|
||||
{
|
||||
if (size != 4) {
|
||||
return omap_badwidth_write32(opaque, addr, value);
|
||||
omap_badwidth_write32(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
OMAP_BAD_REG(addr);
|
||||
|
|
@ -1081,7 +1087,8 @@ static void omap_mpui_write(void *opaque, hwaddr addr,
|
|||
struct omap_mpu_state_s *s = (struct omap_mpu_state_s *) opaque;
|
||||
|
||||
if (size != 4) {
|
||||
return omap_badwidth_write32(opaque, addr, value);
|
||||
omap_badwidth_write32(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
@ -1175,7 +1182,8 @@ static void omap_tipb_bridge_write(void *opaque, hwaddr addr,
|
|||
struct omap_tipb_bridge_s *s = (struct omap_tipb_bridge_s *) opaque;
|
||||
|
||||
if (size < 2) {
|
||||
return omap_badwidth_write16(opaque, addr, value);
|
||||
omap_badwidth_write16(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
@ -1284,7 +1292,8 @@ static void omap_tcmi_write(void *opaque, hwaddr addr,
|
|||
struct omap_mpu_state_s *s = (struct omap_mpu_state_s *) opaque;
|
||||
|
||||
if (size != 4) {
|
||||
return omap_badwidth_write32(opaque, addr, value);
|
||||
omap_badwidth_write32(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
@ -1379,7 +1388,8 @@ static void omap_dpll_write(void *opaque, hwaddr addr,
|
|||
int div, mult;
|
||||
|
||||
if (size != 2) {
|
||||
return omap_badwidth_write16(opaque, addr, value);
|
||||
omap_badwidth_write16(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
if (addr == 0x00) { /* CTL_REG */
|
||||
|
|
@ -1647,7 +1657,8 @@ static void omap_clkm_write(void *opaque, hwaddr addr,
|
|||
};
|
||||
|
||||
if (size != 2) {
|
||||
return omap_badwidth_write16(opaque, addr, value);
|
||||
omap_badwidth_write16(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
@ -1775,7 +1786,8 @@ static void omap_clkdsp_write(void *opaque, hwaddr addr,
|
|||
uint16_t diff;
|
||||
|
||||
if (size != 2) {
|
||||
return omap_badwidth_write16(opaque, addr, value);
|
||||
omap_badwidth_write16(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
@ -1982,7 +1994,8 @@ static void omap_mpuio_write(void *opaque, hwaddr addr,
|
|||
int ln;
|
||||
|
||||
if (size != 2) {
|
||||
return omap_badwidth_write16(opaque, addr, value);
|
||||
omap_badwidth_write16(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (offset) {
|
||||
|
|
@ -2210,7 +2223,8 @@ static void omap_uwire_write(void *opaque, hwaddr addr,
|
|||
int offset = addr & OMAP_MPUI_REG_MASK;
|
||||
|
||||
if (size != 2) {
|
||||
return omap_badwidth_write16(opaque, addr, value);
|
||||
omap_badwidth_write16(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (offset) {
|
||||
|
|
@ -2349,7 +2363,8 @@ static void omap_pwl_write(void *opaque, hwaddr addr,
|
|||
int offset = addr & OMAP_MPUI_REG_MASK;
|
||||
|
||||
if (size != 1) {
|
||||
return omap_badwidth_write8(opaque, addr, value);
|
||||
omap_badwidth_write8(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (offset) {
|
||||
|
|
@ -2444,7 +2459,8 @@ static void omap_pwt_write(void *opaque, hwaddr addr,
|
|||
int offset = addr & OMAP_MPUI_REG_MASK;
|
||||
|
||||
if (size != 1) {
|
||||
return omap_badwidth_write8(opaque, addr, value);
|
||||
omap_badwidth_write8(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (offset) {
|
||||
|
|
@ -2637,7 +2653,8 @@ static void omap_rtc_write(void *opaque, hwaddr addr,
|
|||
time_t ti[2];
|
||||
|
||||
if (size != 1) {
|
||||
return omap_badwidth_write8(opaque, addr, value);
|
||||
omap_badwidth_write8(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (offset) {
|
||||
|
|
@ -3410,9 +3427,14 @@ static void omap_mcbsp_write(void *opaque, hwaddr addr,
|
|||
uint64_t value, unsigned size)
|
||||
{
|
||||
switch (size) {
|
||||
case 2: return omap_mcbsp_writeh(opaque, addr, value);
|
||||
case 4: return omap_mcbsp_writew(opaque, addr, value);
|
||||
default: return omap_badwidth_write16(opaque, addr, value);
|
||||
case 2:
|
||||
omap_mcbsp_writeh(opaque, addr, value);
|
||||
break;
|
||||
case 4:
|
||||
omap_mcbsp_writew(opaque, addr, value);
|
||||
break;
|
||||
default:
|
||||
omap_badwidth_write16(opaque, addr, value);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -3586,7 +3608,8 @@ static void omap_lpg_write(void *opaque, hwaddr addr,
|
|||
int offset = addr & OMAP_MPUI_REG_MASK;
|
||||
|
||||
if (size != 1) {
|
||||
return omap_badwidth_write8(opaque, addr, value);
|
||||
omap_badwidth_write8(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (offset) {
|
||||
|
|
|
|||
|
|
@ -447,7 +447,8 @@ static void omap_eac_write(void *opaque, hwaddr addr,
|
|||
struct omap_eac_s *s = (struct omap_eac_s *) opaque;
|
||||
|
||||
if (size != 2) {
|
||||
return omap_badwidth_write16(opaque, addr, value);
|
||||
omap_badwidth_write16(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
@ -692,7 +693,8 @@ static void omap_sti_write(void *opaque, hwaddr addr,
|
|||
struct omap_sti_s *s = (struct omap_sti_s *) opaque;
|
||||
|
||||
if (size != 4) {
|
||||
return omap_badwidth_write32(opaque, addr, value);
|
||||
omap_badwidth_write32(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
@ -757,7 +759,8 @@ static void omap_sti_fifo_write(void *opaque, hwaddr addr,
|
|||
uint8_t byte = value;
|
||||
|
||||
if (size != 1) {
|
||||
return omap_badwidth_write8(opaque, addr, size);
|
||||
omap_badwidth_write8(opaque, addr, size);
|
||||
return;
|
||||
}
|
||||
|
||||
if (ch == STI_TRACE_CONTROL_CHANNEL) {
|
||||
|
|
@ -1359,7 +1362,8 @@ static void omap_prcm_write(void *opaque, hwaddr addr,
|
|||
struct omap_prcm_s *s = (struct omap_prcm_s *) opaque;
|
||||
|
||||
if (size != 4) {
|
||||
return omap_badwidth_write32(opaque, addr, value);
|
||||
omap_badwidth_write32(opaque, addr, value);
|
||||
return;
|
||||
}
|
||||
|
||||
switch (addr) {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue