motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-01 06:43:53 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

block: add zoned BlockDriver check to block layer

Browse source 
Putting zoned/non-zoned BlockDrivers on top of each other is not
allowed.

Signed-off-by: Sam Li <faithilikerun@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20230508045533.175575-6-faithilikerun@gmail.com
Message-id: 20230324090605.28361-6-faithilikerun@gmail.com
[Adjust commit message prefix as suggested by Philippe Mathieu-Daudé
<philmd@linaro.org> and clarify that the check is about zoned
BlockDrivers.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Sam Li 2023-05-08 12:55:30 +08:00 • committed by Stefan Hajnoczi
parent 50c4bcd496
commit 774c726ceb
4 changed files with 37 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
block/file-posix.c
View file

@ -776,6 +776,18 @@ static int raw_open_common(BlockDriverState *bs, QDict *options,
goto fail;
}
}
#ifdef CONFIG_BLKZONED
/*
* The kernel page cache does not reliably work for writes to SWR zones
* of zoned block device because it can not guarantee the order of writes.
*/
if ((bs->bl.zoned != BLK_Z_NONE) &&
(!(s->open_flags & O_DIRECT))) {
error_setg(errp, "The driver supports zoned devices, and it requires "
"cache.direct=on, which was not specified.");
return -EINVAL; /* No host kernel page cache */
}
#endif
if (S_ISBLK(st.st_mode)) {
#ifdef __linux__