motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-08 02:03:56 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

net/tap-win32: Fix gcc 14 format truncation errors

Browse source 
The patch fixes the following errors generated by GCC 14.2:

../src/net/tap-win32.c:343:19: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 176 [-Werror=format-truncation=]
  343 |              "%s\\%s\\Connection",
      |                   ^~
  344 |              NETWORK_CONNECTIONS_KEY, enum_name);
      |                                       ~~~~~~~~~

../src/net/tap-win32.c:341:9: note: 'snprintf' output between 92 and 347 bytes into a destination of size 256
  341 |         snprintf(connection_string,
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
  342 |              sizeof(connection_string),
      |              ~~~~~~~~~~~~~~~~~~~~~~~~~~
  343 |              "%s\\%s\\Connection",
      |              ~~~~~~~~~~~~~~~~~~~~~
  344 |              NETWORK_CONNECTIONS_KEY, enum_name);
      |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../src/net/tap-win32.c:242:58: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 178 [-Werror=format-truncation=]
  242 |         snprintf (unit_string, sizeof(unit_string), "%s\\%s",
      |                                                          ^~
  243 |                   ADAPTER_KEY, enum_name);
      |                                ~~~~~~~~~

../src/net/tap-win32.c:242:9: note: 'snprintf' output between 79 and 334 bytes into a destination of size 256
  242 |         snprintf (unit_string, sizeof(unit_string), "%s\\%s",
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  243 |                   ADAPTER_KEY, enum_name);
      |                   ~~~~~~~~~~~~~~~~~~~~~~~

../src/net/tap-win32.c:620:52: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 245 [-Werror=format-truncation=]
  620 |     snprintf (device_path, sizeof(device_path), "%s%s%s",
      |                                                    ^~
  621 |               USERMODEDEVICEDIR,
  622 |               device_guid,
      |               ~~~~~~~~~~~
../src/net/tap-win32.c:620:5: note: 'snprintf' output between 16 and 271 bytes into a destination of size 256
  620 |     snprintf (device_path, sizeof(device_path), "%s%s%s",
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  621 |               USERMODEDEVICEDIR,
      |               ~~~~~~~~~~~~~~~~~~
  622 |               device_guid,
      |               ~~~~~~~~~~~~
  623 |               TAPSUFFIX);
      |               ~~~~~~~~~~

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2607
Cc: qemu-stable@nongnu.org
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
This commit is contained in:
Bernhard Beschow 2024-10-08 22:28:42 +02:00 • committed by Jason Wang
parent 96e610b23d
commit 75fe36b4e8
1 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
net/tap-win32.c
View file

@ -214,7 +214,7 @@ static int is_tap_win32_dev(const char *guid)
for (;;) { for (;;) {
char enum_name[256]; char enum_name[256];
char unit_string[256]; g_autofree char *unit_string = NULL;
HKEY unit_key; HKEY unit_key;
char component_id_string[] = "ComponentId"; char component_id_string[] = "ComponentId";
char component_id[256]; char component_id[256];
@ -239,8 +239,7 @@ static int is_tap_win32_dev(const char *guid)
return FALSE; return FALSE;
} }
snprintf (unit_string, sizeof(unit_string), "%s\\%s", unit_string = g_strdup_printf("%s\\%s", ADAPTER_KEY, enum_name);
ADAPTER_KEY, enum_name);
status = RegOpenKeyEx( status = RegOpenKeyEx(
HKEY_LOCAL_MACHINE, HKEY_LOCAL_MACHINE,
@ -315,7 +314,7 @@ static int get_device_guid(
while (!stop) while (!stop)
{ {
char enum_name[256]; char enum_name[256];
char connection_string[256]; g_autofree char *connection_string = NULL;
HKEY connection_key; HKEY connection_key;
char name_data[256]; char name_data[256];
DWORD name_type; DWORD name_type;
@ -338,9 +337,7 @@ static int get_device_guid(
return -1; return -1;
} }
snprintf(connection_string, connection_string = g_strdup_printf("%s\\%s\\Connection",
sizeof(connection_string),
"%s\\%s\\Connection",
NETWORK_CONNECTIONS_KEY, enum_name); NETWORK_CONNECTIONS_KEY, enum_name);
status = RegOpenKeyEx( status = RegOpenKeyEx(
@ -595,7 +592,7 @@ static void tap_win32_free_buffer(tap_win32_overlapped_t *overlapped,
static int tap_win32_open(tap_win32_overlapped_t **phandle, static int tap_win32_open(tap_win32_overlapped_t **phandle,
const char *preferred_name) const char *preferred_name)
{ {
char device_path[256]; g_autofree char *device_path = NULL;
char device_guid[0x100]; char device_guid[0x100];
int rc; int rc;
HANDLE handle; HANDLE handle;
@ -617,7 +614,7 @@ static int tap_win32_open(tap_win32_overlapped_t **phandle,
if (rc) if (rc)
return -1; return -1;
snprintf (device_path, sizeof(device_path), "%s%s%s", device_path = g_strdup_printf("%s%s%s",
USERMODEDEVICEDIR, USERMODEDEVICEDIR,
device_guid, device_guid,
TAPSUFFIX); TAPSUFFIX);