mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-07-27 12:23:53 -06:00
tcx: switch to load_image_mr() and remove prom_addr hack
Previous to the existence of load_image_mr(), the only way to load in the FCode ROM image was to pass in its physical address via qdev properties and use load_image_targphys(). Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
parent
973945804d
commit
7497638642
2 changed files with 1 additions and 4 deletions
|
@ -843,8 +843,7 @@ static void tcx_realizefn(DeviceState *dev, Error **errp)
|
||||||
vmstate_register_ram_global(&s->rom);
|
vmstate_register_ram_global(&s->rom);
|
||||||
fcode_filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, TCX_ROM_FILE);
|
fcode_filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, TCX_ROM_FILE);
|
||||||
if (fcode_filename) {
|
if (fcode_filename) {
|
||||||
ret = load_image_targphys(fcode_filename, s->prom_addr,
|
ret = load_image_mr(fcode_filename, &s->rom);
|
||||||
FCODE_MAX_ROM_SIZE);
|
|
||||||
g_free(fcode_filename);
|
g_free(fcode_filename);
|
||||||
if (ret < 0 || ret > FCODE_MAX_ROM_SIZE) {
|
if (ret < 0 || ret > FCODE_MAX_ROM_SIZE) {
|
||||||
error_report("tcx: could not load prom '%s'", TCX_ROM_FILE);
|
error_report("tcx: could not load prom '%s'", TCX_ROM_FILE);
|
||||||
|
@ -902,7 +901,6 @@ static Property tcx_properties[] = {
|
||||||
DEFINE_PROP_UINT16("width", TCXState, width, -1),
|
DEFINE_PROP_UINT16("width", TCXState, width, -1),
|
||||||
DEFINE_PROP_UINT16("height", TCXState, height, -1),
|
DEFINE_PROP_UINT16("height", TCXState, height, -1),
|
||||||
DEFINE_PROP_UINT16("depth", TCXState, depth, -1),
|
DEFINE_PROP_UINT16("depth", TCXState, depth, -1),
|
||||||
DEFINE_PROP_UINT64("prom_addr", TCXState, prom_addr, -1),
|
|
||||||
DEFINE_PROP_END_OF_LIST(),
|
DEFINE_PROP_END_OF_LIST(),
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
|
@ -491,7 +491,6 @@ static void tcx_init(hwaddr addr, qemu_irq irq, int vram_size, int width,
|
||||||
qdev_prop_set_uint16(dev, "width", width);
|
qdev_prop_set_uint16(dev, "width", width);
|
||||||
qdev_prop_set_uint16(dev, "height", height);
|
qdev_prop_set_uint16(dev, "height", height);
|
||||||
qdev_prop_set_uint16(dev, "depth", depth);
|
qdev_prop_set_uint16(dev, "depth", depth);
|
||||||
qdev_prop_set_uint64(dev, "prom_addr", addr);
|
|
||||||
qdev_init_nofail(dev);
|
qdev_init_nofail(dev);
|
||||||
s = SYS_BUS_DEVICE(dev);
|
s = SYS_BUS_DEVICE(dev);
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue