motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-08 02:03:56 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests/qapi-schema: Tweak to demonstrate buggy member name check

Browse source 
Member name 'u' and names starting with 'has-' or 'has_' are reserved
for the generator.  check_type() enforces this, covered by tests
reserved-member-u and reserved-member-has.

These tests neglect to cover optional members, where the name starts
with '*'.  Tweak reserved-member-u to fix that.  Test
reserved-member-has still covers non-optional members.

This demonstrates the reserved member name check is broken for
optional members.  The next commit will fix it.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210323094025.3569441-7-armbru@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
[Commit message improved slightly]
This commit is contained in:
Markus Armbruster 2021-03-23 10:40:03 +01:00
parent 1444989a3a
commit 73c40b07c6
3 changed files with 16 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/qapi-schema/reserved-member-u.err
View file

@ -1,2 +0,0 @@
reserved-member-u.json: In struct 'Oops':
reserved-member-u.json:7: 'data' member 'u' uses reserved name