motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-11 03:24:58 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

target/arm: Remove arm_free_cc, a64_free_cc

Browse source 
Translators are no longer required to free tcg temporaries.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2023-02-24 16:52:26 -10:00
parent c303abc87e
commit 720923eddd
3 changed files with 4 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

17
target/arm/tcg/translate-a64.c
View file

@ -319,18 +319,13 @@ static void a64_test_cc(DisasCompare64 *c64, int cc)
arm_test_cc(&c32, cc); arm_test_cc(&c32, cc);
/* Sign-extend the 32-bit value so that the GE/LT comparisons work /*
* properly. The NE/EQ comparisons are also fine with this choice. */ * Sign-extend the 32-bit value so that the GE/LT comparisons work
* properly. The NE/EQ comparisons are also fine with this choice.
*/
c64->cond = c32.cond; c64->cond = c32.cond;
c64->value = tcg_temp_new_i64(); c64->value = tcg_temp_new_i64();
tcg_gen_ext_i32_i64(c64->value, c32.value); tcg_gen_ext_i32_i64(c64->value, c32.value);
arm_free_cc(&c32);
}
static void a64_free_cc(DisasCompare64 *c64)
{
tcg_temp_free_i64(c64->value);
} }
static void gen_rebuild_hflags(DisasContext *s) static void gen_rebuild_hflags(DisasContext *s)
@ -5315,7 +5310,6 @@ static void disas_cc(DisasContext *s, uint32_t insn)
tcg_t0 = tcg_temp_new_i32(); tcg_t0 = tcg_temp_new_i32();
arm_test_cc(&c, cond); arm_test_cc(&c, cond);
tcg_gen_setcondi_i32(tcg_invert_cond(c.cond), tcg_t0, c.value, 0); tcg_gen_setcondi_i32(tcg_invert_cond(c.cond), tcg_t0, c.value, 0);
arm_free_cc(&c);
/* Load the arguments for the new comparison. */ /* Load the arguments for the new comparison. */
if (is_imm) { if (is_imm) {
@ -5435,8 +5429,6 @@ static void disas_cond_select(DisasContext *s, uint32_t insn)
tcg_gen_movcond_i64(c.cond, tcg_rd, c.value, zero, t_true, t_false); tcg_gen_movcond_i64(c.cond, tcg_rd, c.value, zero, t_true, t_false);
} }
a64_free_cc(&c);
if (!sf) { if (!sf) {
tcg_gen_ext32u_i64(tcg_rd, tcg_rd); tcg_gen_ext32u_i64(tcg_rd, tcg_rd);
} }
@ -6256,7 +6248,6 @@ static void disas_fp_csel(DisasContext *s, uint32_t insn)
tcg_gen_movcond_i64(c.cond, t_true, c.value, tcg_constant_i64(0), tcg_gen_movcond_i64(c.cond, t_true, c.value, tcg_constant_i64(0),
t_true, t_false); t_true, t_false);
tcg_temp_free_i64(t_false); tcg_temp_free_i64(t_false);
a64_free_cc(&c);
/* Note that sregs & hregs write back zeros to the high bits, /* Note that sregs & hregs write back zeros to the high bits,
and we've already done the zero-extension. */ and we've already done the zero-extension. */

9
target/arm/tcg/translate.c
View file

@ -754,13 +754,6 @@ void arm_test_cc(DisasCompare *cmp, int cc)
cmp->value_global = global; cmp->value_global = global;
} }
void arm_free_cc(DisasCompare *cmp)
{
if (!cmp->value_global) {
tcg_temp_free_i32(cmp->value);
}
}
void arm_jump_cc(DisasCompare *cmp, TCGLabel *label) void arm_jump_cc(DisasCompare *cmp, TCGLabel *label)
{ {
tcg_gen_brcondi_i32(cmp->cond, cmp->value, 0, label); tcg_gen_brcondi_i32(cmp->cond, cmp->value, 0, label);
@ -771,7 +764,6 @@ void arm_gen_test_cc(int cc, TCGLabel *label)
DisasCompare cmp; DisasCompare cmp;
arm_test_cc(&cmp, cc); arm_test_cc(&cmp, cc);
arm_jump_cc(&cmp, label); arm_jump_cc(&cmp, label);
arm_free_cc(&cmp);
} }
void gen_set_condexec(DisasContext *s) void gen_set_condexec(DisasContext *s)
@ -9125,7 +9117,6 @@ static bool trans_CSEL(DisasContext *s, arg_CSEL *a)
arm_test_cc(&c, a->fcond); arm_test_cc(&c, a->fcond);
tcg_gen_movcond_i32(c.cond, rn, c.value, zero, rn, rm); tcg_gen_movcond_i32(c.cond, rn, c.value, zero, rn, rm);
arm_free_cc(&c);
store_reg(s, a->rd, rn); store_reg(s, a->rd, rn);
tcg_temp_free_i32(rm); tcg_temp_free_i32(rm);

1
target/arm/tcg/translate.h
View file

@ -304,7 +304,6 @@ static inline void gen_a64_update_pc(DisasContext *s, target_long diff)
#endif #endif
void arm_test_cc(DisasCompare *cmp, int cc); void arm_test_cc(DisasCompare *cmp, int cc);
void arm_free_cc(DisasCompare *cmp);
void arm_jump_cc(DisasCompare *cmp, TCGLabel *label); void arm_jump_cc(DisasCompare *cmp, TCGLabel *label);
void arm_gen_test_cc(int cc, TCGLabel *label); void arm_gen_test_cc(int cc, TCGLabel *label);
MemOp pow2_align(unsigned i); MemOp pow2_align(unsigned i);